Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd the compose function to the List package. #847
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Mar 24, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Mar 24, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This should start in the list-extra package. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 24, 2017
Contributor
Or in a function-extra package. Even in core, I doubt that List would be the right module for this function.
|
Or in a function-extra package. Even in core, I doubt that List would be the right module for this function. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tibastral
Mar 25, 2017
Contributor
Thank you for your feedback. I keep using this function everywhere, simple, generic and I would say it also can give ideas to people, and is kind of a "functional programming only" concept, that's why I think it could be a good function to have here.
|
Thank you for your feedback. I keep using this function everywhere, simple, generic and I would say it also can give ideas to people, and is kind of a "functional programming only" concept, that's why I think it could be a good function to have here. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Mar 25, 2017
Contributor
But have you read the following paragraph?
https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions
It clearly indicates that you should close your pull request here and instead target it at another package. It even points you to elm-community.
And as said above, having this function be called List.compose seems wrong. It is not about composing list(s).
|
But have you read the following paragraph? https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions It clearly indicates that you should close your pull request here and instead target it at another package. It even points you to And as said above, having this function be called |
evancz
closed this
Mar 25, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Better in |
tibastral commentedMar 24, 2017
The compose function is useful when we want to apply a chain of functions to a single argument.