New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the compose function to the List package. #847

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@tibastral
Contributor

tibastral commented Mar 24, 2017

The compose function is useful when we want to apply a chain of functions to a single argument.

Add the compose function to the List package.
The compose function is useful when we want to apply a chain of functions to a single argument.
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Mar 24, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Mar 24, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Mar 24, 2017

Contributor

This should start in the list-extra package.

Contributor

mgold commented Mar 24, 2017

This should start in the list-extra package.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 24, 2017

Contributor

Or in a function-extra package. Even in core, I doubt that List would be the right module for this function.

Contributor

jvoigtlaender commented Mar 24, 2017

Or in a function-extra package. Even in core, I doubt that List would be the right module for this function.

@tibastral

This comment has been minimized.

Show comment
Hide comment
@tibastral

tibastral Mar 25, 2017

Contributor

Thank you for your feedback. I keep using this function everywhere, simple, generic and I would say it also can give ideas to people, and is kind of a "functional programming only" concept, that's why I think it could be a good function to have here.

Contributor

tibastral commented Mar 25, 2017

Thank you for your feedback. I keep using this function everywhere, simple, generic and I would say it also can give ideas to people, and is kind of a "functional programming only" concept, that's why I think it could be a good function to have here.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Mar 25, 2017

Contributor

But have you read the following paragraph?

https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions

It clearly indicates that you should close your pull request here and instead target it at another package. It even points you to elm-community.

And as said above, having this function be called List.compose seems wrong. It is not about composing list(s).

Contributor

jvoigtlaender commented Mar 25, 2017

But have you read the following paragraph?

https://github.com/elm-lang/core/blob/master/CONTRIBUTING.md#adding-new-functions

It clearly indicates that you should close your pull request here and instead target it at another package. It even points you to elm-community.

And as said above, having this function be called List.compose seems wrong. It is not about composing list(s).

@evancz evancz closed this Mar 25, 2017

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 25, 2017

Member

Better in *-extra and we can bring in things later in a coherent way.

Member

evancz commented Mar 25, 2017

Better in *-extra and we can bring in things later in a coherent way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment