/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In documentation, note on equality on regular expressions #848

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@jvoigtlaender @process-bot @evancz
@jvoigtlaender
Contributor

jvoigtlaender commented Mar 28, 2017

Equality (==) does not work properly on Regexes, but this is not currently warned against in the documentation.

See an example issue https://github.com/elm-lang/core/issues/839 where this came up.

This pull request expands an existing note on types for which == should not be used, to include mention of Regex.
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Mar 28, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Mar 28, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz evancz added the docs label Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment