Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upJson.Decode.keyValuePairs need not reverse order #849
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Apr 1, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Apr 1, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
added a commit
that referenced
this pull request
Jul 8, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jul 8, 2017
Member
I was going through this library the other day and wasn't sure if I should put things in order. Based on seeing this PR and #863, I figured I'd go for it.
|
I was going through this library the other day and wasn't sure if I should put things in order. Based on seeing this PR and #863, I figured I'd go for it. |
zwilias commentedApr 1, 2017
Reversing the entries does not break any guarantees: an object is an unordered collection of key-value pairs as per the spec.
However, browsers generally respect order of definition when dealing with objects, and reverting that order when converting to an ordered data-structure violates the principle of least surprise.