New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Basics tests #85

Merged
merged 3 commits into from Jan 9, 2015

Conversation

Projects
None yet
3 participants
@deadfoxygrandpa
Contributor

deadfoxygrandpa commented Jan 9, 2015

I went through and added at least one test for every function defined in Basics. I used the example cases written in the documentation where available. All of these tests currently pass.

Some of these are pretty trivial tests, but I was thinking why not just add one anyway?

If this is something that you think is acceptable or worth doing, I can continue adding tests like this to other files in core.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 9, 2015

Member

Awesome, this looks great! I think it'd be great to have more comprehensive test coverage on other modules, but you should coordinate with @laszlopandy because he is working on some changes to make a bunch of functions total. I guess there won't be merge conflicts with the kinds of changes going on?

Member

evancz commented Jan 9, 2015

Awesome, this looks great! I think it'd be great to have more comprehensive test coverage on other modules, but you should coordinate with @laszlopandy because he is working on some changes to make a bunch of functions total. I guess there won't be merge conflicts with the kinds of changes going on?

evancz pushed a commit that referenced this pull request Jan 9, 2015

@evancz evancz merged commit ded0a61 into elm:master Jan 9, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 9, 2015

Member

I think the Json.Decode module is a great candidate for tests at the moment. I think @laszlopandy tried to think of some tests for Result and couldn't think of anything super meaningful. In any case, yeah, this is awesome!

Member

evancz commented Jan 9, 2015

I think the Json.Decode module is a great candidate for tests at the moment. I think @laszlopandy tried to think of some tests for Result and couldn't think of anything super meaningful. In any case, yeah, this is awesome!

@laszlopandy

This comment has been minimized.

Show comment
Hide comment
@laszlopandy

laszlopandy Jan 9, 2015

Contributor

Wow awesome work. Don't worry about merge conflicts, I can fix them and I'm not really touching Basics.

Contributor

laszlopandy commented Jan 9, 2015

Wow awesome work. Don't worry about merge conflicts, I can fix them and I'm not really touching Basics.

@deadfoxygrandpa deadfoxygrandpa deleted the deadfoxygrandpa:tests branch Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment