Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd more Basics tests #85
Conversation
deadfoxygrandpa
added some commits
Jan 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jan 9, 2015
Member
Awesome, this looks great! I think it'd be great to have more comprehensive test coverage on other modules, but you should coordinate with @laszlopandy because he is working on some changes to make a bunch of functions total. I guess there won't be merge conflicts with the kinds of changes going on?
|
Awesome, this looks great! I think it'd be great to have more comprehensive test coverage on other modules, but you should coordinate with @laszlopandy because he is working on some changes to make a bunch of functions total. I guess there won't be merge conflicts with the kinds of changes going on? |
pushed a commit
that referenced
this pull request
Jan 9, 2015
evancz
merged commit ded0a61
into
elm:master
Jan 9, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jan 9, 2015
Member
I think the Json.Decode module is a great candidate for tests at the moment. I think @laszlopandy tried to think of some tests for Result and couldn't think of anything super meaningful. In any case, yeah, this is awesome!
|
I think the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
laszlopandy
Jan 9, 2015
Contributor
Wow awesome work. Don't worry about merge conflicts, I can fix them and I'm not really touching Basics.
|
Wow awesome work. Don't worry about merge conflicts, I can fix them and I'm not really touching Basics. |
deadfoxygrandpa commentedJan 9, 2015
I went through and added at least one test for every function defined in Basics. I used the example cases written in the documentation where available. All of these tests currently pass.
Some of these are pretty trivial tests, but I was thinking why not just add one anyway?
If this is something that you think is acceptable or worth doing, I can continue adding tests like this to other files in core.