/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document `Cmd.batch` #856

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fosskers @process-bot @evancz
@fosskers

fosskers commented Apr 24, 2017 •
edited
Edited 1 time
  • @fosskers fosskers edited Apr 24, 2017 (most recent)

From #799 and #730 , it has been noticed by multiple users that the execution order of a List Cmd folded by Cmd.batch is not always the same as the order they were defined in the List. This might come from an unconscious assumption that Cmd.batch works like sequence :: [IO a] -> IO [a] instead of like its async cousin Task.

This PR documents the Cmd.batch function to help avoid confusion for future users.
@fosskers
Document `Cmd.batch` 
- Execution order of folded `Cmd` is not guaranteed, but it is
  reasonable to expect it to have been. This clears up potential
  confusion.
Unverified
This user has not uploaded their public key yet.
GPG key ID: B12DBF9E6B930BED Learn about signing commits
d933f87
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Apr 24, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Apr 24, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jul 8, 2017

Member

This is documented in the dev branch. See https://github.com/elm-lang/core/blob/dev/src/Platform/Cmd.elm for details.

Thank you for the PR!
Member

evancz commented Jul 8, 2017

This is documented in the dev branch. See https://github.com/elm-lang/core/blob/dev/src/Platform/Cmd.elm for details.

Thank you for the PR!

@evancz evancz closed this Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment