New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in filterMap documentation. #871

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@soveran

soveran commented Jun 10, 2017

No description provided.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jun 10, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jun 10, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Jun 11, 2017

Contributor

Why is that a "fix"?

Someone of age 19 is a teenager. It's nineteen.

Contributor

jvoigtlaender commented Jun 11, 2017

Why is that a "fix"?

Someone of age 19 is a teenager. It's nineteen.

@soveran

This comment has been minimized.

Show comment
Hide comment
@soveran

soveran Jun 11, 2017

I think you are absolutely right. I was reading the Elm Guide and its section on Maybe. In the paragraph about "Partial Functions", the getTeenAge function uses if 13 <= age && age <= 18, then refers to List.filterMap for further reading. As I followed the link, I encountered this mismatching example and I thought it was an error. Others my also find it confusing, but I think you are correct and we can close this issue now :-)

soveran commented Jun 11, 2017

I think you are absolutely right. I was reading the Elm Guide and its section on Maybe. In the paragraph about "Partial Functions", the getTeenAge function uses if 13 <= age && age <= 18, then refers to List.filterMap for further reading. As I followed the link, I encountered this mismatching example and I thought it was an error. Others my also find it confusing, but I think you are correct and we can close this issue now :-)

@soveran soveran closed this Jun 11, 2017

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender
Contributor

jvoigtlaender commented Jun 11, 2017

@soveran soveran deleted the soveran:doc-typo branch Jun 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment