Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConfiguration of eslint #875
Conversation
owanturist
added some commits
Jun 19, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jun 20, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jun 20, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 1, 2017
Member
I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules"
I also know that I'm not super familiar with this tooling, so it is very likely that if it was merged, it would get out of date and end up not being used anyway.
|
I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules" I also know that I'm not super familiar with this tooling, so it is very likely that if it was merged, it would get out of date and end up not being used anyway. |
owanturist commentedJun 20, 2017
•
edited
Edited 1 time
-
owanturist
edited Jun 20, 2017 (most recent)
Hello! Thanks for great language/tool/ecosystem/world.. !
Some days ago I have researched source code of elm-lang/core and I found eslint configuration. When I verified native code with this config I understood that eslint was disabled (995 problems: 739 errors, 256 warnings).
I think eslint is great tool which can increase quality of code and prevent errors. So I prepared several of pull requests and the first of them it is configuration of eslint with ignore and editorconfig (because I didn't want change settings of code editor every time while I wrote that pull requests). I divided commits with different layers of changes: some of them change rules, another change the comment format, etc.. If any layer will not meet expectations I'll just remove commit with the layer.
I want to help with making of pure and clear native code with checking of anything by eslint and this PR will make opportunity of this more realistic.