Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEslint/fix Native/Utils.js #876
Conversation
owanturist
added some commits
Jun 19, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jun 20, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jun 20, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
| _elm_lang$core$Array$toList | ||
| _elm_lang$core$Dict$toList | ||
| _elm_lang$core$Set$toList | ||
| */ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Aug 1, 2017
Member
I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules"
|
I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules" |
owanturist commentedJun 20, 2017
Hello! This PR includes changes of code for passing of eslint checking. The PR based on #875 and can be merged only after that.
Before: 157 problems (132 errors, 25 warnings)
After: 22 problems (0 errors, 22 warnings)
I have another branches with changes for every file with native code and if the PR will merged or if the idea with eslint integration will approved I'll continue creation of PRs.