New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint/fix Native/Utils.js #876

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@owanturist

owanturist commented Jun 20, 2017

Hello! This PR includes changes of code for passing of eslint checking. The PR based on #875 and can be merged only after that.

Before: 157 problems (132 errors, 25 warnings)
After: 22 problems (0 errors, 22 warnings)

I have another branches with changes for every file with native code and if the PR will merged or if the idea with eslint integration will approved I'll continue creation of PRs.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jun 20, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jun 20, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

_elm_lang$core$Array$toList
_elm_lang$core$Dict$toList
_elm_lang$core$Set$toList
*/

This comment has been minimized.

@owanturist

owanturist Jun 20, 2017

It's more legal and pure way for indicate of globals

@owanturist

owanturist Jun 20, 2017

It's more legal and pure way for indicate of globals

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Aug 1, 2017

Member

I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules"

Member

evancz commented Aug 1, 2017

I don't think I want to do this. I'm okay with the current process, and I sometimes do odd things for performance or asset size that I would not want to be "against the rules"

@evancz evancz closed this Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment