Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up`sequence` is not stack-safe #881
+1
−6
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Jul 2, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 2, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
evancz
merged commit 8ffb64c
into
elm:dev
Jul 7, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Jul 7, 2017
Member
Having the new foldr implementation be entirely in Elm makes me more comfortable with this change. Thanks!
|
Having the new |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
zwilias
Jul 7, 2017
Member
Absolutely! The more of core we can have in Elm, the more comfortable I
feel with this type of change :)
…On 8 Jul 2017 00:04, "Evan Czaplicki" ***@***.***> wrote:
Having the new foldr implementation be entirely in Elm makes me more
comfortable with this change. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/elm-lang/core/pull/881#issuecomment-313803986>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA_YW05AAgLOTIvIQpTg55_1KF00dY5Xks5sLqt4gaJpZM4OLjxk>
.
|
Absolutely! The more of core we can have in Elm, the more comfortable I
feel with this type of change :)
…On 8 Jul 2017 00:04, "Evan Czaplicki" ***@***.***> wrote:
Having the new foldr implementation be entirely in Elm makes me more
comfortable with this change. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/elm-lang/core/pull/881#issuecomment-313803986>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA_YW05AAgLOTIvIQpTg55_1KF00dY5Xks5sLqt4gaJpZM4OLjxk>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zwilias commentedJul 2, 2017
This probably should not come up in any realistic scenario, but then again, it's just one less thing that can go wrong.