Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove |> and <| from the Random module. #883
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jul 8, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 8, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Jul 8, 2017
Member
Looks good to me! Thank you!
Also, of course, very glad to have the better implementation :) Just needed to be going through a bunch of core stuff to do the review!
|
Looks good to me! Thank you! Also, of course, very glad to have the better implementation :) Just needed to be going through a bunch of core stuff to do the review! |
mgold commentedJul 8, 2017
•
edited
Edited 1 time
-
mgold
edited Jul 8, 2017 (most recent)
As requested. Also includes some very minor revisions to docs and removes the
mul32function that was never called.I copied the file to a separate directory and it compiled, but extra eyes to make sure I didn't do anything stupid would be great.
And thank you so much for merging the previous PR!