Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake it possible for elm-test to use core's Random #887
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Jul 19, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Jul 19, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
src/Random.elm
| {-| A generator that produces a seed that is independent of any other seed in | ||
| the program. These seeds will generate their own unqiue sequences of random |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mgold
Jul 28, 2017
Contributor
Force-pushed a commit that resolves both of @basile-henry's comments.
|
Force-pushed a commit that resolves both of @basile-henry's comments. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
Is this on top of the increased randomness and addition of constant?
@mgold, can explain to me in Slack what needs to be done and why? I do not recall what this is all about.
|
Is this on top of the increased randomness and addition of @mgold, can explain to me in Slack what needs to be done and why? I do not recall what this is all about. |
elm
deleted a comment from
basile-henry
Mar 9, 2018
elm
deleted a comment from
mgold
Mar 9, 2018
evancz
merged commit 88e6a91
into
elm:dev
Mar 9, 2018
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 9, 2018
Member
Ended up talking it through, and I understand the particular details and decisions now. Thank you @mgold!
|
Ended up talking it through, and I understand the particular details and decisions now. Thank you @mgold! |
mgold commentedJul 19, 2017
This adds
Random.independentSeed, which allows the creation of randomseeds that are completely independent of each other. No amount of taking
random numbers from one seed will "wind" it to the same place as
another, such that they produce the same values.
This feature is essential to elm-test's ability to reproduce failures
because it allows each fuzz test to consume as many random values as it
needs without affecting tests that run after it. It means we can run
failing tests alone without disturbing the failure. It also makes it
possible to parallelize test runs.
If this PR is merged, elm-test will be able to use core's Random
implementation instead of my third party library. cc @rtfeldman