New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible for elm-test to use core's Random #887

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@mgold
Contributor

mgold commented Jul 19, 2017

This adds Random.independentSeed, which allows the creation of random
seeds that are completely independent of each other. No amount of taking
random numbers from one seed will "wind" it to the same place as
another, such that they produce the same values.

This feature is essential to elm-test's ability to reproduce failures
because it allows each fuzz test to consume as many random values as it
needs without affecting tests that run after it. It means we can run
failing tests alone without disturbing the failure. It also makes it
possible to parallelize test runs.

If this PR is merged, elm-test will be able to use core's Random
implementation instead of my third party library. cc @rtfeldman

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Jul 19, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Jul 19, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@basile-henry

This looks pretty useful! 👍

Show outdated Hide outdated src/Random.elm
{-| A generator that produces a seed that is independent of any other seed in
the program. These seeds will generate their own unqiue sequences of random

This comment has been minimized.

@basile-henry
@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jul 28, 2017

Contributor

Force-pushed a commit that resolves both of @basile-henry's comments.

Contributor

mgold commented Jul 28, 2017

Force-pushed a commit that resolves both of @basile-henry's comments.

@mgold mgold referenced this pull request Jul 29, 2017

Open

Planning for 0.19 and 5.0.0 #191

6 of 11 tasks complete
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 7, 2018

Member

Is this on top of the increased randomness and addition of constant?

@mgold, can explain to me in Slack what needs to be done and why? I do not recall what this is all about.

Member

evancz commented Mar 7, 2018

Is this on top of the increased randomness and addition of constant?

@mgold, can explain to me in Slack what needs to be done and why? I do not recall what this is all about.

Make it possible for elm-test to use core's Random
This adds `Random.independentSeed`, which allows the creation of random
seeds that are completely independent of each other. No amount of taking
random numbers from one seed will "wind" it to the same place as
another, such that they produce the same values.

This feature is essential to elm-test's ability to reproduce failures
because it allows each fuzz test to consume as many random values as it
needs without affecting tests that run after it. It means we can run
failing tests alone without disturbing the failure. It also makes it
possible to parallelize test runs.

If this PR is merged, elm-test will be able to use core's Random
implementation instead of my third party library.

@elm elm deleted a comment from basile-henry Mar 9, 2018

@elm elm deleted a comment from mgold Mar 9, 2018

@evancz evancz merged commit 88e6a91 into elm:dev Mar 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 9, 2018

Member

Ended up talking it through, and I understand the particular details and decisions now. Thank you @mgold! 😄

Member

evancz commented Mar 9, 2018

Ended up talking it through, and I understand the particular details and decisions now. Thank you @mgold! 😄

@mgold mgold deleted the mgold:random-independent-seed branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment