Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove String.toInt docs: "+" and "-" return Ok NaN #901
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
process-bot
Aug 23, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Aug 23, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
Aug 24, 2017
Member
That's a bug, not a feature! I forget if it is fixed in the upcoming release, but I'd like to fix this in 0.19
|
That's a bug, not a feature! I forget if it is fixed in the upcoming release, but I'd like to fix this in 0.19 |
evancz
closed this
Aug 24, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fdbeirao commentedAug 23, 2017
This caught me by surprise today, so I hope this PR helps future me.