/core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equality check of oneOf decoder #905

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@evancz evancz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shuhei @process-bot
@shuhei

shuhei commented Sep 2, 2017

Fixes #904

  • Renaming the existing _Json_listEquality as _Json_arrayEquality because it actually works on JavaScript arrays instead of Lists
  • Adding a new _Json_listEquality function that works on Elm Lists
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 2, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 2, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@jinjor jinjor requested a review from evancz Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment