Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Tuple.mapBoth function #908
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Sep 15, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Sep 15, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
minond
Sep 15, 2017
Ummm... I think I'm missing something. Build is failing with an elm-make: elm-package.json: openBinaryFile: does not exist (No such file or directory) error, which I'm getting locally as well. I'm looking around for some technical documentation on contributing to core but haven't been able to find it or anything that is helpful with dealing with this error. Could someone point me in the right direction?
minond
commented
Sep 15, 2017
|
Ummm... I think I'm missing something. Build is failing with an |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Sep 15, 2017
Contributor
Maybe the most important information to you, wanting to contribute to core, is this document: https://github.com/elm-lang/core/blob/master/.github/CONTRIBUTING.md
Note in particular what it says in the "Adding New Functions" section.
|
Maybe the most important information to you, wanting to contribute to Note in particular what it says in the "Adding New Functions" section. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
minond
Sep 15, 2017
@jvoigtlaender thanks for sending me that. What's documented there totally makes sense. If this seems like it belongs in an *-extra package instead, then I can move it.
minond
commented
Sep 15, 2017
|
@jvoigtlaender thanks for sending me that. What's documented there totally makes sense. If this seems like it belongs in an *-extra package instead, then I can move it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jvoigtlaender
Sep 15, 2017
Contributor
Contributing it to https://github.com/elm-community/basics-extra would make sense. That package already has a section of tuple functions (http://package.elm-lang.org/packages/elm-community/basics-extra/2.1.2/Basics-Extra#=%3E).
|
Contributing it to https://github.com/elm-community/basics-extra would make sense. That package already has a section of tuple functions (http://package.elm-lang.org/packages/elm-community/basics-extra/2.1.2/Basics-Extra#=%3E). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This is already in the |
minond commentedSep 15, 2017
Helper function when you need to apply a function to both elements in a Tuple. Like a combination of
mapFirstandmapSecond: