New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuple.mapBoth function #908

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@minond

minond commented Sep 15, 2017

Helper function when you need to apply a function to both elements in a Tuple. Like a combination of mapFirst and mapSecond:

mapBoth ((+) 1) (6, 8) == (7, 9)
@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Sep 15, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Sep 15, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@minond

This comment has been minimized.

Show comment
Hide comment
@minond

minond Sep 15, 2017

Ummm... I think I'm missing something. Build is failing with an elm-make: elm-package.json: openBinaryFile: does not exist (No such file or directory) error, which I'm getting locally as well. I'm looking around for some technical documentation on contributing to core but haven't been able to find it or anything that is helpful with dealing with this error. Could someone point me in the right direction?

minond commented Sep 15, 2017

Ummm... I think I'm missing something. Build is failing with an elm-make: elm-package.json: openBinaryFile: does not exist (No such file or directory) error, which I'm getting locally as well. I'm looking around for some technical documentation on contributing to core but haven't been able to find it or anything that is helpful with dealing with this error. Could someone point me in the right direction?

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 15, 2017

Contributor

Maybe the most important information to you, wanting to contribute to core, is this document: https://github.com/elm-lang/core/blob/master/.github/CONTRIBUTING.md

Note in particular what it says in the "Adding New Functions" section.

Contributor

jvoigtlaender commented Sep 15, 2017

Maybe the most important information to you, wanting to contribute to core, is this document: https://github.com/elm-lang/core/blob/master/.github/CONTRIBUTING.md

Note in particular what it says in the "Adding New Functions" section.

@minond

This comment has been minimized.

Show comment
Hide comment
@minond

minond Sep 15, 2017

@jvoigtlaender thanks for sending me that. What's documented there totally makes sense. If this seems like it belongs in an *-extra package instead, then I can move it.

minond commented Sep 15, 2017

@jvoigtlaender thanks for sending me that. What's documented there totally makes sense. If this seems like it belongs in an *-extra package instead, then I can move it.

@jvoigtlaender

This comment has been minimized.

Show comment
Hide comment
@jvoigtlaender

jvoigtlaender Sep 15, 2017

Contributor

Contributing it to https://github.com/elm-community/basics-extra would make sense. That package already has a section of tuple functions (http://package.elm-lang.org/packages/elm-community/basics-extra/2.1.2/Basics-Extra#=%3E).

Contributor

jvoigtlaender commented Sep 15, 2017

Contributing it to https://github.com/elm-community/basics-extra would make sense. That package already has a section of tuple functions (http://package.elm-lang.org/packages/elm-community/basics-extra/2.1.2/Basics-Extra#=%3E).

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Sep 15, 2017

Member

This is already in the dev branch I believe!

Member

evancz commented Sep 15, 2017

This is already in the dev branch I believe!

@evancz evancz closed this Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment