New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more docs to `Time` module #920

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@dbrgn

dbrgn commented Nov 19, 2017

Elm beginner here.

Initially I did not really understand how inSeconds etc work, so I tried to add some docs.

I hope the changes are correct. I did not manage to generate a preview of the docs. This is what I tried:

$ cd path/to/core
$ elm-make --docs=docs.json

...but the docs.json file is empty, so it can't be fed to http://package.elm-lang.org/help/docs-preview.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Nov 19, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Nov 19, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz May 22, 2018

Member

This will be moving to https://github.com/elm-lang/time which does things in a much clearer way. It will be out with the next release of Elm, and I hope it clarifies things with a bunch of new docs in the README and such.

Member

evancz commented May 22, 2018

This will be moving to https://github.com/elm-lang/time which does things in a much clearer way. It will be out with the next release of Elm, and I hope it clarifies things with a bunch of new docs in the README and such.

@evancz evancz closed this May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment