Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew dict implementation #925
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Dec 6, 2017
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Dec 6, 2017
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Skinney
Dec 6, 2017
Contributor
Just wanted to mention @justinmimbs, who did some impressive work on this code.
|
Just wanted to mention @justinmimbs, who did some impressive work on this code. |
evancz
and others
added some commits
Jan 31, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
Do you mind getting the conflicts resolved? I think we should try to see the impact on code size in applications that use dictionaries!
|
Do you mind getting the conflicts resolved? I think we should try to see the impact on code size in applications that use dictionaries! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evancz
Mar 7, 2018
Member
I think messy commits are kind of lame, so if it is easier, just close and open a new PR with just the changes in a commit or something. Or not. Whatever works!
|
I think messy commits are kind of lame, so if it is easier, just close and open a new PR with just the changes in a commit or something. Or not. Whatever works! |
Skinney commentedDec 6, 2017
A new Dict implementation based on Left-Leaning Red-Black trees (LLRB). Performance numbers can be found here: https://discourse.elm-lang.org/t/new-dict-implementation-for-elm-now-done/174/3
The code that is commented out helps validating the invariants of a LLRB tree. It's not something that should be built in production builds, or even used by regular users, but it's invaluable when making changes to the data structure.