New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dict implementation #925

Closed
wants to merge 9 commits into
base: dev
from

Conversation

Projects
None yet
4 participants
@Skinney
Contributor

Skinney commented Dec 6, 2017

A new Dict implementation based on Left-Leaning Red-Black trees (LLRB). Performance numbers can be found here: https://discourse.elm-lang.org/t/new-dict-implementation-for-elm-now-done/174/3

The code that is commented out helps validating the invariants of a LLRB tree. It's not something that should be built in production builds, or even used by regular users, but it's invaluable when making changes to the data structure.

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Dec 6, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Dec 6, 2017

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@Skinney

This comment has been minimized.

Show comment
Hide comment
@Skinney

Skinney Dec 6, 2017

Contributor

Just wanted to mention @justinmimbs, who did some impressive work on this code.

Contributor

Skinney commented Dec 6, 2017

Just wanted to mention @justinmimbs, who did some impressive work on this code.

evancz and others added some commits Jan 31, 2018

Remove Tuple.apply
I think this will ultimately be a mistake, kind of like the
curry/uncurry pair it was meant to replace. (Also like flip)
[0.19] Char.fromCode - typo
`c` isn't defined here
@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 7, 2018

Member

Do you mind getting the conflicts resolved? I think we should try to see the impact on code size in applications that use dictionaries!

Member

evancz commented Mar 7, 2018

Do you mind getting the conflicts resolved? I think we should try to see the impact on code size in applications that use dictionaries!

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Mar 7, 2018

Member

I think messy commits are kind of lame, so if it is easier, just close and open a new PR with just the changes in a commit or something. Or not. Whatever works!

Member

evancz commented Mar 7, 2018

I think messy commits are kind of lame, so if it is easier, just close and open a new PR with just the changes in a commit or something. Or not. Whatever works!

@Skinney Skinney closed this Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment