Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew dict implementation #948
Conversation
Skinney
added some commits
Dec 6, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Mar 7, 2018
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Mar 7, 2018
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Skinney
May 9, 2018
Contributor
New commit strips out the "sorted optimization" to save on compiled asset size.
The new Dict implementation is still faster than the current implementation, and without sorted opts it should also be smaller.
|
New commit strips out the "sorted optimization" to save on compiled asset size. |
Skinney commentedMar 7, 2018
A new Dict implementation based on Left-Leaning Red-Black trees (LLRB). Performance numbers can be found here: https://discourse.elm-lang.org/t/new-dict-implementation-for-elm-now-done/174/3
The code that is commented out helps validating the invariants of a LLRB tree. It's not something that should be built in production builds, or even used by regular users, but it's invaluable when making changes to the data structure.
Also includes code from justinmimbs (fromSortedList and friends).