New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dict implementation #948

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Skinney
Contributor

Skinney commented Mar 7, 2018

A new Dict implementation based on Left-Leaning Red-Black trees (LLRB). Performance numbers can be found here: https://discourse.elm-lang.org/t/new-dict-implementation-for-elm-now-done/174/3

The code that is commented out helps validating the invariants of a LLRB tree. It's not something that should be built in production builds, or even used by regular users, but it's invaluable when making changes to the data structure.

Also includes code from justinmimbs (fromSortedList and friends).

@process-bot

This comment has been minimized.

Show comment
Hide comment
@process-bot

process-bot Mar 7, 2018

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot commented Mar 7, 2018

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@Skinney

This comment has been minimized.

Show comment
Hide comment
@Skinney

Skinney May 9, 2018

Contributor

New commit strips out the "sorted optimization" to save on compiled asset size.
The new Dict implementation is still faster than the current implementation, and without sorted opts it should also be smaller.

Contributor

Skinney commented May 9, 2018

New commit strips out the "sorted optimization" to save on compiled asset size.
The new Dict implementation is still faster than the current implementation, and without sorted opts it should also be smaller.

@Skinney Skinney closed this May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment