Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify (==) Json.Encode.Value limitations #951
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
process-bot
Mar 15, 2018
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
commented
Mar 15, 2018
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
osteele
Mar 15, 2018
It doesn't look like the CI failure elm-make: elm-package.json: openBinaryFile: does not exist (No such file or directory) is caused by this doc-only change.
osteele
commented
Mar 15, 2018
•
|
It doesn't look like the CI failure |
osteele commentedMar 15, 2018
The documentation for (==) implied (to me) that (==) would work on
Json.Encode.Values that didn't include functions. This is not the case.
This change attempts to clarify this. It doesn't go into exact detail
about the failure cases (one order works, another doesn't), because it
seemed like this had to do with implementation details that are better
not relied on; instead, it attempts to steer the reader away for using
(==) on Json.Encode.Values at all.
See https://discourse.elm-lang.org/t/json-encode-value-equality/898
for discussion.