Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew Dict implementation using Left-Leaning RB-Trees. #959
+220
−293
Conversation
Skinney
changed the title from
New Dict implementation using Left-Leaning RRB-Trees.
to
New Dict implementation using Left-Leaning RB-Trees.
May 21, 2018
evancz
merged commit c564391
into
elm:master
May 22, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
evancz
May 22, 2018
Member
Just got a chance to do the review. Looks great to me! Excited to get it out to folks
|
Just got a chance to do the review. Looks great to me! Excited to get it out to folks |
forki
referenced this pull request
Aug 22, 2018
Open
[CompilerPerf] Removed TaggedCollections from Compiler #5463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Skinney commentedMay 14, 2018
This new implementation is a drop-in replacement, offering faster inserts (~170% increase) and faster removals (~30% faster).
The code is also compiles to less js. Recent testing shows that this implementation produces 488 less bytes after minification and gzip.
I've made as few changes to the original code as possible.