New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `import Text` to fix runtime error. #96

Merged
merged 2 commits into from Jan 14, 2015

Conversation

Projects
None yet
2 participants
@mgold
Contributor

mgold commented Jan 14, 2015

Fixes #93.

I threw in a comment in hopes of guarding against a regression.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 14, 2015

Member

Does it fix things to import Native.Text as well? I don't think it's a huge deal, but might be something to consider.

Member

evancz commented Jan 14, 2015

Does it fix things to import Native.Text as well? I don't think it's a huge deal, but might be something to consider.

@mgold

This comment has been minimized.

Show comment
Hide comment
@mgold

mgold Jan 14, 2015

Contributor

That also works. Updated. Native communicates that it's internal without a comment, so that sounds good to me.

Contributor

mgold commented Jan 14, 2015

That also works. Updated. Native communicates that it's internal without a comment, so that sounds good to me.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jan 14, 2015

Member

Cool, thank you!

Member

evancz commented Jan 14, 2015

Cool, thank you!

evancz pushed a commit that referenced this pull request Jan 14, 2015

Merge pull request #96 from mgold/import-text-fix-hoverable
Add `import Text` to fix runtime error.

@evancz evancz merged commit 461f491 into elm:master Jan 14, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment