New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate function declaration. Error in Google Closure Compiler #966

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@albertdahlin

albertdahlin commented Jun 27, 2018

This fix is commited on top of the 5.1.1 tag

Google Closure Compiler complains about this:

ERROR - Duplicate let / const / class / function declaration in the same scope is not allowed.
function badIndex(index, nestedProblems)
         ^^^^^^^^

The function badIndex is declared twice in the Native.Json module.
This looks like a PR merge mistake so I just removed the duplicate declaration.

@evancz

This comment has been minimized.

Show comment
Hide comment
@evancz

evancz Jun 27, 2018

Member

This should be removed in the development branch of the library. Thanks for the report though!

Member

evancz commented Jun 27, 2018

This should be removed in the development branch of the library. Thanks for the report though!

@evancz evancz closed this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment