Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implementation for deadEndsToString #9

Open
jdmnd opened this issue Aug 26, 2018 · 9 comments

Comments

@jdmnd
Copy link

commented Aug 26, 2018

https://github.com/elm/parser/blob/master/src/Parser.elm#L170
The documentation implies a basic working implementation, but currently it's just a placeholder:

deadEndsToString deadEnds =
  "TODO deadEndsToString"

blawlor pushed a commit to blawlor/parser that referenced this issue Dec 31, 2018

@blawlor

This comment has been minimized.

Copy link

commented Dec 31, 2018

I've created a PR with a proposed implementation for this function.
All comments welcome.

@bburdette

This comment has been minimized.

Copy link

commented Dec 31, 2018

I too have a PR for this issue, which has been sitting since september!

@blawlor

This comment has been minimized.

Copy link

commented Jan 1, 2019

Hi @bburdette - I didn't see your PR on this ticket. If I had I would happily just have used your fork!

@blawlor

This comment has been minimized.

Copy link

commented Jan 1, 2019

Ok - I see what happened. Your PR is associated with a closed duplicate (#16 ) of this issue. Anyhoo - to the commiter(s) on this project, please use @bburdette 's PR over mine.

@bburdette

This comment has been minimized.

Copy link

commented Jan 1, 2019

Its ok with me either way! Would be nice for this to get merged sometime though. Maybe a major revision of the lib is waiting in the wings though.

@harrysarson

This comment has been minimized.

Copy link

commented May 5, 2019

Same as above but copied into a gist for folk reading this in more than two weeks time: https://gist.github.com/harrysarson/234436a9f0517e14d0fd67fd63ba6619

@Erudition

This comment has been minimized.

Copy link

commented Jul 15, 2019

Yikes. Still just a TODO...

@drewwestphal

This comment has been minimized.

Copy link

commented Aug 7, 2019

???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.