Will ELMAH be ported to ASP.NET Core? #407

Open
mgmccarthy opened this Issue Oct 12, 2016 · 19 comments

Comments

Projects
None yet
7 participants
@mgmccarthy

I'm having a hard time finding information about this. I realize there is cloud-based elmah.io project (https://elmah.io/) that is has a beta out for .NET Core, but that's a different project and in no way affiliated with ELMAH (at least I think it is)...

any info you could provide would be helpful.

@atifaziz atifaziz added the question label Oct 13, 2016

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Oct 13, 2016

Member

I realize there is cloud-based elmah.io project…but that's a different project and in no way affiliated with ELMAH (at least I think it is)...

That's correct. It's a completely different project run by @ThomasArdal.

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

Member

atifaziz commented Oct 13, 2016

I realize there is cloud-based elmah.io project…but that's a different project and in no way affiliated with ELMAH (at least I think it is)...

That's correct. It's a completely different project run by @ThomasArdal.

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Oct 13, 2016

Contributor

@mgmccarthy I'm Thomas, the founder of elmah.io and as @atifaziz says, it's a different project with what turned out as a bad naming choice.

I have promissed Atif to look at ELMAH for ASP.NET Core. I decided to implement the beta for elmah.io first, to find out how middleware are implemented for ASP.NET Core. I feel that the implementation is in pretty good shape right now and I would love to merge the implementation back to the ELMAH project.

@atifaziz Would you mind taking a look at the implementation for Elmah.Io.AspNetCore and share if you would want some of the code. Maybe just for inspiration. I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

Contributor

ThomasArdal commented Oct 13, 2016

@mgmccarthy I'm Thomas, the founder of elmah.io and as @atifaziz says, it's a different project with what turned out as a bad naming choice.

I have promissed Atif to look at ELMAH for ASP.NET Core. I decided to implement the beta for elmah.io first, to find out how middleware are implemented for ASP.NET Core. I feel that the implementation is in pretty good shape right now and I would love to merge the implementation back to the ELMAH project.

@atifaziz Would you mind taking a look at the implementation for Elmah.Io.AspNetCore and share if you would want some of the code. Maybe just for inspiration. I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Oct 14, 2016

Member

@ThomasArdal Thanks for sharing that Thomas but it's only a very small piece (posting an error) of the entire feature set and so the bulk of the work (UI, mailing, authorisation, log stores, refactoring of code & packages, testability, etc.) is still pending and requires a fair amount of time.

I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

Correct.

Member

atifaziz commented Oct 14, 2016

@ThomasArdal Thanks for sharing that Thomas but it's only a very small piece (posting an error) of the entire feature set and so the bulk of the work (UI, mailing, authorisation, log stores, refactoring of code & packages, testability, etc.) is still pending and requires a fair amount of time.

I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

Correct.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Oct 14, 2016

Contributor

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?

Contributor

ThomasArdal commented Oct 14, 2016

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Oct 14, 2016

Member

A new branch on top of the owin one probably makes sense but before that, I think that the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles. Then merge that structure into the OWIN version and then start the ASP.NET Core port. That's just thinking from the top of my head.

On 14 Oct 2016, at 07:14, Thomas Ardal notifications@github.com wrote:

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Member

atifaziz commented Oct 14, 2016

A new branch on top of the owin one probably makes sense but before that, I think that the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles. Then merge that structure into the OWIN version and then start the ASP.NET Core port. That's just thinking from the top of my head.

On 14 Oct 2016, at 07:14, Thomas Ardal notifications@github.com wrote:

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Oct 14, 2016

Contributor

@atifaziz I'm not sure about the state of the OWIN branch. Would it make sense to create a 2.0 branch from master and make the split there? Then pick the changes from the owin branch that makes sense for core and put them into the 2.0 branch? Or do you believe that the owin branch is in a state where we could build 2.0 from that?

Contributor

ThomasArdal commented Oct 14, 2016

@atifaziz I'm not sure about the state of the OWIN branch. Would it make sense to create a 2.0 branch from master and make the split there? Then pick the changes from the owin branch that makes sense for core and put them into the 2.0 branch? Or do you believe that the owin branch is in a state where we could build 2.0 from that?

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Oct 14, 2016

Member

@ThomasArdal master represents the latest development, which is already 2.0.

Member

atifaziz commented Oct 14, 2016

@ThomasArdal master represents the latest development, which is already 2.0.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Oct 14, 2016

Contributor

@atifaziz Ok. Is ELMAH on the owin branch still based on modules? Was looking into creating middleware for core instead.

Contributor

ThomasArdal commented Oct 14, 2016

@atifaziz Ok. Is ELMAH on the owin branch still based on modules? Was looking into creating middleware for core instead.

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Oct 14, 2016

Member

@ThomasArdal ASP.NET Core borrows the idea of middleware from OWIN. In fact, it even supports OWIN middleware. So naturally the owin branch isn't based on modules. Have a look at Owin.cs where most of the attempt was done & works to a very large extent. See the following extension methods that setup the middleware in the pipeline via IAppBuilder:

I mostly stopped working on all this when I found out that ASP.NET vNext (at the time) wasn't going to be based on OWIN. Wanted the let the dust settle down.

Member

atifaziz commented Oct 14, 2016

@ThomasArdal ASP.NET Core borrows the idea of middleware from OWIN. In fact, it even supports OWIN middleware. So naturally the owin branch isn't based on modules. Have a look at Owin.cs where most of the attempt was done & works to a very large extent. See the following extension methods that setup the middleware in the pipeline via IAppBuilder:

I mostly stopped working on all this when I found out that ASP.NET vNext (at the time) wasn't going to be based on OWIN. Wanted the let the dust settle down.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Oct 21, 2016

Contributor

@atifaziz Makes sense. I will have a look at porting the OWIN middleware to ASP.NET Core middleware when time allows. Thanks.

Contributor

ThomasArdal commented Oct 21, 2016

@atifaziz Makes sense. I will have a look at porting the OWIN middleware to ASP.NET Core middleware when time allows. Thanks.

@atifaziz atifaziz referenced this issue in elmah/www Nov 10, 2016

Closed

When will elmah support .net core? #33

@milla

This comment has been minimized.

Show comment
Hide comment
@milla

milla Nov 11, 2016

Is the release date for elmah .net core planned :)

milla commented Nov 11, 2016

Is the release date for elmah .net core planned :)

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Nov 11, 2016

Member

@milla See my earlier comment:

If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

Member

atifaziz commented Nov 11, 2016

@milla See my earlier comment:

If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

@mgmccarthy

This comment has been minimized.

Show comment
Hide comment
@mgmccarthy

mgmccarthy Dec 18, 2016

@ThomasArdal any progress made on porting the OWIN middleware to ASP.NET Core middleware?

I'd like to jump in and help, but I'm currently using most of my free time on another open source project which I would like to use ELMAH on.

@ThomasArdal any progress made on porting the OWIN middleware to ASP.NET Core middleware?

I'd like to jump in and help, but I'm currently using most of my free time on another open source project which I would like to use ELMAH on.

@ThomasArdal

This comment has been minimized.

Show comment
Hide comment
@ThomasArdal

ThomasArdal Dec 19, 2016

Contributor

@mgmccarthy No :( Haven't had time to look at it either.

Contributor

ThomasArdal commented Dec 19, 2016

@mgmccarthy No :( Haven't had time to look at it either.

@304NotModified 304NotModified referenced this issue in NLog/NLog.Elmah May 15, 2017

Open

.NET Core support? #13

@jpsingleton jpsingleton referenced this issue in jpsingleton/ANCLAFS Aug 5, 2017

Open

ELMAH #29

@ThomasArdal ThomasArdal referenced this issue in ElmahCore/ElmahCore Dec 9, 2017

Open

Merging this to the ELMAH project? #1

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Dec 18, 2017

Member

the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles.

This was done in #418.

Member

atifaziz commented Dec 18, 2017

the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles.

This was done in #418.

@szalapski

This comment has been minimized.

Show comment
Hide comment
@szalapski

szalapski Apr 4, 2018

Any updates on how to use ELMAH or something similar in .NET Core?

Any updates on how to use ELMAH or something similar in .NET Core?

@atifaziz

This comment has been minimized.

Show comment
Hide comment
@atifaziz

atifaziz Apr 5, 2018

Member

@szalapski The update is that I'm afraid it's no different than my initial comment:

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

I have shipped ASP.NET Core projects since and I'm beginning to feel the itch or miss ELMAH myself but the pain hasn't reached a level where I feel compelled to dive in alone.

As for something similar for .NET Core, I'm not aware of anything except ElmahCore by @barestan.

Member

atifaziz commented Apr 5, 2018

@szalapski The update is that I'm afraid it's no different than my initial comment:

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

I have shipped ASP.NET Core projects since and I'm beginning to feel the itch or miss ELMAH myself but the pain hasn't reached a level where I feel compelled to dive in alone.

As for something similar for .NET Core, I'm not aware of anything except ElmahCore by @barestan.

@frattaro

This comment has been minimized.

Show comment
Hide comment
@frattaro

frattaro May 5, 2018

I don't know why Microsoft doesn't pick this up. This library is the main reason I don't use .net core (System.DirectoryServices is another, but that is coming out in core 2.1).

frattaro commented May 5, 2018

I don't know why Microsoft doesn't pick this up. This library is the main reason I don't use .net core (System.DirectoryServices is another, but that is coming out in core 2.1).

@ofuochi

This comment has been minimized.

Show comment
Hide comment
@ofuochi

ofuochi Jun 24, 2018

@frattaro This is exactly my case too. I can't afford the subscription for elmah.io :(

ofuochi commented Jun 24, 2018

@frattaro This is exactly my case too. I can't afford the subscription for elmah.io :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment