Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will ELMAH be ported to ASP.NET Core? #407

Open
mgmccarthy opened this issue Oct 12, 2016 · 19 comments
Open

Will ELMAH be ported to ASP.NET Core? #407

mgmccarthy opened this issue Oct 12, 2016 · 19 comments
Labels

Comments

@mgmccarthy
Copy link

@mgmccarthy mgmccarthy commented Oct 12, 2016

I'm having a hard time finding information about this. I realize there is cloud-based elmah.io project (https://elmah.io/) that is has a beta out for .NET Core, but that's a different project and in no way affiliated with ELMAH (at least I think it is)...

any info you could provide would be helpful.

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Oct 13, 2016

I realize there is cloud-based elmah.io project…but that's a different project and in no way affiliated with ELMAH (at least I think it is)...

That's correct. It's a completely different project run by @ThomasArdal.

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Oct 13, 2016

@mgmccarthy I'm Thomas, the founder of elmah.io and as @atifaziz says, it's a different project with what turned out as a bad naming choice.

I have promissed Atif to look at ELMAH for ASP.NET Core. I decided to implement the beta for elmah.io first, to find out how middleware are implemented for ASP.NET Core. I feel that the implementation is in pretty good shape right now and I would love to merge the implementation back to the ELMAH project.

@atifaziz Would you mind taking a look at the implementation for Elmah.Io.AspNetCore and share if you would want some of the code. Maybe just for inspiration. I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Oct 14, 2016

@ThomasArdal Thanks for sharing that Thomas but it's only a very small piece (posting an error) of the entire feature set and so the bulk of the work (UI, mailing, authorisation, log stores, refactoring of code & packages, testability, etc.) is still pending and requires a fair amount of time.

I know there's an OWIN branch on ELMAH, but I guess that one were never actually ported to Core, right?

Correct.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Oct 14, 2016

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Oct 14, 2016

A new branch on top of the owin one probably makes sense but before that, I think that the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles. Then merge that structure into the OWIN version and then start the ASP.NET Core port. That's just thinking from the top of my head.

On 14 Oct 2016, at 07:14, Thomas Ardal notifications@github.com wrote:

@atifaziz I know 😄 Should we create a new branch for core or do you want to continue the work on the owin branch?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Oct 14, 2016

@atifaziz I'm not sure about the state of the OWIN branch. Would it make sense to create a 2.0 branch from master and make the split there? Then pick the changes from the owin branch that makes sense for core and put them into the 2.0 branch? Or do you believe that the owin branch is in a state where we could build 2.0 from that?

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Oct 14, 2016

@ThomasArdal master represents the latest development, which is already 2.0.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Oct 14, 2016

@atifaziz Ok. Is ELMAH on the owin branch still based on modules? Was looking into creating middleware for core instead.

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Oct 14, 2016

@ThomasArdal ASP.NET Core borrows the idea of middleware from OWIN. In fact, it even supports OWIN middleware. So naturally the owin branch isn't based on modules. Have a look at Owin.cs where most of the attempt was done & works to a very large extent. See the following extension methods that setup the middleware in the pipeline via IAppBuilder:

I mostly stopped working on all this when I found out that ASP.NET vNext (at the time) wasn't going to be based on OWIN. Wanted the let the dust settle down.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Oct 21, 2016

@atifaziz Makes sense. I will have a look at porting the OWIN middleware to ASP.NET Core middleware when time allows. Thanks.

@milla
Copy link

@milla milla commented Nov 11, 2016

Is the release date for elmah .net core planned :)

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Nov 11, 2016

@milla See my earlier comment:

If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

@mgmccarthy
Copy link
Author

@mgmccarthy mgmccarthy commented Dec 18, 2016

@ThomasArdal any progress made on porting the OWIN middleware to ASP.NET Core middleware?

I'd like to jump in and help, but I'm currently using most of my free time on another open source project which I would like to use ELMAH on.

@ThomasArdal
Copy link
Contributor

@ThomasArdal ThomasArdal commented Dec 19, 2016

@mgmccarthy No :( Haven't had time to look at it either.

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Dec 18, 2017

the existing repo needs to be refactored into different ones: one for the core bits and then separate ones for the error log implementations so each can have its own issues, versions and release cycles.

This was done in #418.

@szalapski
Copy link

@szalapski szalapski commented Apr 4, 2018

Any updates on how to use ELMAH or something similar in .NET Core?

@atifaziz
Copy link
Member

@atifaziz atifaziz commented Apr 5, 2018

@szalapski The update is that I'm afraid it's no different than my initial comment:

Will ELMAH be ported to ASP.NET Core?

It's more of an “if & when time permits” than a definite “no”. If it depends entirely on me then I'm afraid for you that it'll be on my agenda and when I'm ready to ship my first ASP.NET Core project. If some people have already jumped on that bandwagon, well-versed in ASP.NET Core, care about backward compatibility & would like to help make it happen sooner then it could.

I have shipped ASP.NET Core projects since and I'm beginning to feel the itch or miss ELMAH myself but the pain hasn't reached a level where I feel compelled to dive in alone.

As for something similar for .NET Core, I'm not aware of anything except ElmahCore by @barestan.

@frattaro
Copy link

@frattaro frattaro commented May 5, 2018

I don't know why Microsoft doesn't pick this up. This library is the main reason I don't use .net core (System.DirectoryServices is another, but that is coming out in core 2.1).

@ofuochi
Copy link

@ofuochi ofuochi commented Jun 24, 2018

@frattaro This is exactly my case too. I can't afford the subscription for elmah.io :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants