Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Mergining libtrianlges #13

Merged
merged 5 commits into from Feb 17, 2013

Conversation

Projects
None yet
2 participants

Someone messaged my awhile ago asking to have my libtriangles relicensed under the lgpl, so they could include it in MCAD. That never happened, so here's my pull request. Let me know if I need to do anything else to the file, like explicitly mention the author or license in the file.

I also included a folder called "examples". inside is "example.libtriangles.scad". If you don't want the folder, I can move it into the main folder.

Owner

elmom commented Feb 16, 2013

Debian at least wantäs explicit licenses, and that includes the names of
the copyright holders.

The examples would be best included as tests, you can follow the other
test_*.scad files. So no module level geometry, and sane default
arguments would be nice.

Thanks for the addition

Elmo

On 02/15/2013 11:18 PM, traverseda wrote:

Someone messaged my awhile ago asking to have my libtriangles
relicensed under the lgpl, so they could include it in MCAD. That
never happened, so here's my pull request. Let me know if I need to do
anything else to the file, like explicitly mention the author or
license in the file.

I also included a folder called "examples". inside is
"example.libtriangles.scad". If you don't want the folder, I can move
it into the main folder.


    You can merge this Pull Request by running

git pull https://github.com/traverseda/MCAD master

Or view, comment on, or merge it at:

#13

    Commit Summary

Alright, fixed. It currently defaults to nothing, but that's emulating how the built in constants like cube() work.

Owner

elmom commented Feb 16, 2013

About the test_ file, I meant no file level geometry, testing code should be inside (several) "module test_*(...){...}"

Otherwise it seems good

Removed test_libtriangles. I was under the mistaken impression is pro…
…vided a set of examples, so you could see at a glance the result of the code. This doesn't really need a test function.

Not much point to the test file then, in this instance. It was always more of a examples thing. I simply removed it. It wasn't necessary anyway, just something so you could see at a glance the different library options and what they did.

elmom added a commit that referenced this pull request Feb 17, 2013

@elmom elmom merged commit 6079e6d into elmom:master Feb 17, 2013

hyperair pushed a commit to hyperair/MCAD that referenced this pull request Jul 15, 2014

Merge pull request #13 from achiestdragon/master
Capture MCAD work by achiestdragon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment