Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all versions] loginctl is missing a reload command #105

Closed
Yamakuzure opened this Issue Dec 13, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Yamakuzure
Copy link
Collaborator

Yamakuzure commented Dec 13, 2018

to reload a changed configuration, elogind can be sent a SIGHUP, and it will reload.

However, systemctl has a "reload" command, which is much more convenient than sending a signal using kill and similar.

loginctl should therefore get a reload command, too, and best with a soon service release for both v238 and v239 series.

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator Author

Yamakuzure commented Dec 13, 2018

If the restarting of elogind leading to bug #104 was caused by the wish to reload its configuration, adding that command to loginctl becomes even more important.

@Yamakuzure Yamakuzure self-assigned this Dec 14, 2018

@Yamakuzure Yamakuzure pinned this issue Dec 14, 2018

Yamakuzure added a commit that referenced this issue Jan 5, 2019

Prep v239.4: Fix cg_path_get_session() error return
When no session could be found, the systemd code returns -ENXIO,
while the elogind specific part returns -ENOENT.
The problem is, that the first is understood as a simple lack of data
and is not considered to be a hard error in calling functions, while
the latter is wreaking havoc.

This ultimately led to:
Bug: #45 #105
Signed-Off-By: Sven Eden <sven.eden@prydeworx.com>

Yamakuzure added a commit that referenced this issue Feb 16, 2019

Add a "reload" command to loginctl
To reload a changed configuration, elogind can be sent a SIGHUP, and
it will reload.

But systemctl has a "reload" command, which is much more convenient
than sending a signal using `kill` and similar.

`loginctl` should therefore get a reload command, too

Bug: #105
Closes: #105
Signed-off-by: Sven Eden <sven.eden@prydeworx.com>

@Yamakuzure Yamakuzure unpinned this issue Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.