Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elogind-243.9999 doesn't build with '-Defi=false' #150

Closed
perfect7gentleman opened this issue Jan 22, 2020 · 2 comments
Closed

elogind-243.9999 doesn't build with '-Defi=false' #150

perfect7gentleman opened this issue Jan 22, 2020 · 2 comments
Assignees
Labels
bug

Comments

@perfect7gentleman
Copy link

@perfect7gentleman perfect7gentleman commented Jan 22, 2020

[134/461] /usr/lib/python-exec/python3.8/meson --internal exe --capture src/test/test-hashmap-ordered.c -- /usr/bin/awk -f ../elogind-243.9999/src/test/test-hashmap-ordered.awk ../elogind-243.9999/src/test/test-hashmap-plain.c
ninja: job failed: x86_64-pc-linux-gnu-gcc -Iloginctl@exe -I. -I../elogind-243.9999 -Isrc/basic -I../elogind-243.9999/src/basic -I../elogind-243.9999/src/boot -Isrc/shared -I../elogind-243.9999/src/shared -Isrc/systemd -I../elogind-243.9999/src/systemd -Isrc/journal -I../elogind-243.9999/src/journal -Isrc/login -I../elogind-243.9999/src/login -Isrc/core -I../elogind-243.9999/src/core -I../elogind-243.9999/src/libelogind/sd-bus -I../elogind-243.9999/src/libelogind/sd-device -I../elogind-243.9999/src/libelogind/sd-event -I../elogind-243.9999/src/libelogind/sd-hwdb -I../elogind-243.9999/src/libelogind/sd-id128 -Isrc/sleep -I../elogind-243.9999/src/sleep -Isrc/update-utmp -I../elogind-243.9999/src/update-utmp -I../elogind-243.9999/ -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -O3 -Wextra -Werror=undef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=missing-declarations -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wmissing-noreturn -Wimplicit-fallthrough=5 -Wshadow -Wendif-labels -Wstrict-aliasing=2 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Wno-format-signedness -Wno-error=nonnull -Wno-maybe-uninitialized -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -Werror=shadow -include config.h -march=native -mtune=native -O3 -fomit-frame-pointer -fno-plt -fno-stack-protector -ftree-vectorize -flto=5 -fuse-ld=bfd -fuse-linker-plugin -s -pthread -MD -MQ 'loginctl@exe/src_login_eloginctl.c.o' -MF 'loginctl@exe/src_login_eloginctl.c.o.d' -o 'loginctl@exe/src_login_eloginctl.c.o' -c ../elogind-243.9999/src/login/eloginctl.c
../elogind-243.9999/src/login/eloginctl.c: In function ‘start_special’:
../elogind-243.9999/src/login/eloginctl.c:704:13: error: implicit declaration of function ‘prepare_firmware_setup’ [-Werror=implicit-function-declaration]
  704 |         r = prepare_firmware_setup(bus);
      |             ^~~~~~~~~~~~~~~~~~~~~~
../elogind-243.9999/src/login/eloginctl.c:704:13: warning: nested extern declaration of ‘prepare_firmware_setup’ [-Wnested-externs]
cc1: some warnings being treated as errors
ninja: subcommand failed
@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

@Yamakuzure Yamakuzure commented Jan 27, 2020

Oops... Sorry, I missed that one. All EFI related should have stubs if -Defi=false.

I am currently upgrading and cleaning up 'master', so we have a working development branch again. When I have finished that, hopefully tonight, I'll fix that mistake.

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

@Yamakuzure Yamakuzure commented Jan 27, 2020

  • "All EFI related functions should have stubs"
@Yamakuzure Yamakuzure added the bug label Jan 27, 2020
@Yamakuzure Yamakuzure self-assigned this Jan 27, 2020
@Yamakuzure Yamakuzure closed this in b63da31 Feb 1, 2020
Yamakuzure added a commit that referenced this issue Feb 1, 2020
All EFI-related functions have to provide neutral stubs if -Defi is
set to false. This way no care has to be taken when using these
functions.

For some extra functions needed by elogind this scheme was broken and
is now fixed.

Bug: #150
Closes: #150
Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
Cherry-picked-from: b63da31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.