New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elogind-239.9999: meson_options.txt:83:0: ERROR: Option name debug is reserved. #76

Closed
perfect7gentleman opened this Issue Sep 25, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@perfect7gentleman
Copy link

perfect7gentleman commented Sep 25, 2018

Preparing source in /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999 ...
 * Applying elogind-238.1-docs.patch ...                                                                                            [ ok ]
>>> Source prepared.
>>> Configuring source in /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999 ...
meson --buildtype plain --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload -Ddocdir=/usr/share/doc/elogind-239.9999 -Dhtmldir=/usr/share/doc/elogind-239.9999/html -Dpamlibdir=/lib64/security -Dudevrulesdir=/lib/udev/rules.d --libdir=/usr/lib64 -Drootlibdir=/lib64 -Drootlibexecdir=/lib64/elogind -Drootprefix=/ -Dbashcompletiondir=/usr/share/bash-completion/completions -Dzshcompletiondir=/usr/share/zsh/site-functions -Dman=auto -Dsmack=true -Dcgroup-controller=openrc -Ddefault-hierarchy=hybrid -Ddefault-kill-user-processes=false -Dacl=true --buildtype release -Dhtml=false -Dpam=true -Dselinux=false /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999 /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999-build
The Meson build system
Version: 0.48.0
Source dir: /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999
Build dir: /tmp/portage/sys-auth/elogind-239.9999/work/elogind-239.9999-build
Build type: native build

meson_options.txt:83:0: ERROR:  Option name debug is reserved.
@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Sep 25, 2018

This is new. I have meson-0.47.1, and there is no hint about that.

However, that was an upstream option, I'll check what the systemd devs did about it.

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Sep 25, 2018

Hmm... still there in systemd-stable/v239-stable and systemd/master.

@Yamakuzure Yamakuzure self-assigned this Sep 25, 2018

@Yamakuzure Yamakuzure added the bug label Sep 25, 2018

@perfect7gentleman

This comment has been minimized.

Copy link
Author

perfect7gentleman commented Sep 25, 2018

imo, this is meson-0.48 bug as it works with 0.47.1

@perfect7gentleman

This comment has been minimized.

Copy link
Author

perfect7gentleman commented Sep 25, 2018

@perfect7gentleman

This comment has been minimized.

Copy link
Author

perfect7gentleman commented Sep 26, 2018

that patch helped

diff -Nuar a/meson.build b/meson.build
--- a/meson.build	2018-09-26 07:23:58.187911859 +0700
+++ b/meson.build	2018-09-26 07:25:18.816949364 +0700
@@ -895,7 +895,7 @@
 #if 1 /// additional elogind debug mode
 enable_debug_elogind = false
 #endif // 1
-foreach name : get_option('debug')
+foreach name : get_option('debug-extra')
         if name == 'hashmap'
                 enable_debug_hashmap = true
         elif name == 'mmap-cache'
diff -Nuar a/meson_options.txt b/meson_options.txt
--- a/meson_options.txt	2018-09-26 07:21:48.805247014 +0700
+++ b/meson_options.txt	2018-09-26 07:23:12.387322521 +0700
@@ -80,7 +80,7 @@
 option('valgrind', type : 'boolean', value : false,
        description : 'do extra operations to avoid valgrind warnings')
 #if 1 /// Add an extra debugging option for elogind
-option('debug', type : 'array', choices : ['elogind', 'hashmap', 'mmap-cache'], value : [],
+option('debug-extra', type : 'array', choices : ['elogind', 'hashmap', 'mmap-cache'], value : [],
        description : 'enable extra debugging')
 #endif // 1
 
@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Sep 26, 2018

Yes, they simply renamed the option at Debian. I wonder why there isn't anything in the systemd repos, yet. (*)

Changing that option means, that, once backported, all Gentoo ebuilds have to be changed. I'll keep that in mind. However, I'd like to wait and see what the systemd devs decide to do about it.

(*) They have a closed Issue about it: systemd/systemd#9883
That issue resulted in the above commit: systemd/systemd@8f6b442

What I do not understand is, why I haven't seen that in systemd:master, that I pulled yesterday. The commit is dated August 23rd...

...hang on...

Oh for HEAVENS SAKE!
I did a git fetch ; git checkout master as I was on v239 tag and then forgot to pull!

Yamakuzure added a commit that referenced this issue Sep 26, 2018

meson: rename -Ddebug to -Ddebug-extra
Meson added -Doptimization and -Ddebug options, which obviously causes
a conflict with our -Ddebug options. Let's rename it.

Fixes #76.

Yamakuzure added a commit that referenced this issue Sep 26, 2018

meson: rename -Ddebug to -Ddebug-extra
Meson added -Doptimization and -Ddebug options, which obviously causes
a conflict with our -Ddebug options. Let's rename it.

Fixes #76.

Yamakuzure added a commit that referenced this issue Sep 26, 2018

meson: rename -Ddebug to -Ddebug-extra
Meson added -Doptimization and -Ddebug options, which obviously causes
a conflict with our -Ddebug options. Let's rename it.

Fixes #76.

Yamakuzure added a commit that referenced this issue Sep 26, 2018

meson: rename -Ddebug to -Ddebug-extra
Meson added -Doptimization and -Ddebug options, which obviously causes
a conflict with our -Ddebug options. Let's rename it.

Fixes #76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment