New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to register SIGINT handler [elogind 239.1] #90

Closed
DareDeb-User opened this Issue Oct 28, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@DareDeb-User
Copy link
Contributor

DareDeb-User commented Oct 28, 2018

Hi,
I'm running elogind in Debian/Unstable with runit as init/supervisor:
At each shutdown i see that the parent runsv of elogind exits -1, which according to runsv man page means that the run script didn't exits normally;
in the logs i see messages like this
auth.err: Oct 28 12:43:50 elogind[2365]: Failed to register SIGINT handler: Device or resource busy .

Also (possibly related) when i try to send an interrupt signal to elogind, the whole Desktop (LXQT) crashes, even if I build with -Ddefault-kill-user-processes=false: is this crash an expected behavior?

@Yamakuzure Yamakuzure self-assigned this Oct 29, 2018

@Yamakuzure Yamakuzure added the bug label Oct 29, 2018

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Oct 29, 2018

Wow... I found that message in dmesg. Never sent SIGINT to elogind myself, it would terminate my Plasma session.
That LXQT comes crashing down on your machine is curious. Which elogind version are you running?

@DareDeb-User

This comment has been minimized.

Copy link
Contributor Author

DareDeb-User commented Oct 29, 2018

Which elogind version are you running?

now i have v239 (build from v239-stable branch); i'm 99% sure that i don't have this issue with v238 (if you want 100% sure i can try to downgrade to 238)

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Oct 29, 2018

I have not heard of this before. There was a problem when the signal handler got introduced, but that's it. Therefore I am rather sure that you are correct and this is newly introduced in 239.

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Oct 30, 2018

It will take a while. The systemd devs have pushed hundreds of commits to v238-stable and v239-stable. I am currently migrating the v239 branch, and will look into this signal thing next.

@DareDeb-User

This comment has been minimized.

Copy link
Contributor Author

DareDeb-User commented Oct 31, 2018

Sure, no rush here.
Thanks

Yamakuzure added a commit that referenced this issue Nov 9, 2018

Prep v239.2: Fix signal registration failure (#90)
The behaviour of sd_event_add_signal() has changed, it is no longer
neccessary to mask the signal beforehand.

Actually the masking causes it to be ignored, and thus the
registration of the signal handler to fail.

Bug: #90
Closes: #90
Signed-off-by: Sven Eden <sven.eden@prydeworx.com>

@Yamakuzure Yamakuzure closed this in 3a5de57 Nov 9, 2018

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Nov 9, 2018

I re-open this. Unfortunately I wasn't only on the wrong track, I also completely misunderstood some internal mechanics, so the "fix" doesn't really fix anything.

Sorry for the fuss. To my defense I can only say that my train neared my destination and I wanted that one finished.
Note to self: If you need to hurry too much, better postpone next time!

@Yamakuzure Yamakuzure reopened this Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment