Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if _POSIX_C_SOURCE is defined #114

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@Derriick
Copy link
Contributor

Derriick commented Feb 20, 2019

No description provided.

@Derriick Derriick force-pushed the Derriick:_POSIX_C_SOURCE-fix branch from 16cbe0f to 92c8939 Feb 20, 2019

@Yamakuzure Yamakuzure self-requested a review Feb 21, 2019

@Yamakuzure Yamakuzure self-assigned this Feb 21, 2019

@Yamakuzure
Copy link
Collaborator

Yamakuzure left a comment

Please adapt the change to not remove the original line.
See #113 (comment) for how this should look.

The text in the mask explanation is up to you. You only have to make sure that the keyword "elogind" appears in it.

@Derriick Derriick force-pushed the Derriick:_POSIX_C_SOURCE-fix branch from 92c8939 to 0242711 Feb 21, 2019

@Derriick Derriick force-pushed the Derriick:_POSIX_C_SOURCE-fix branch from 0242711 to c3a71d1 Feb 21, 2019

@Derriick

This comment has been minimized.

Copy link
Contributor Author

Derriick commented Feb 21, 2019

I have changed the commit as you proposed in #113 (comment).

The text in the mask explanation is up to you. You only have to make sure that the keyword "elogind" appears in it.

What do you mean ? What do I have to do ?

@Derriick

This comment has been minimized.

Copy link
Contributor Author

Derriick commented Feb 21, 2019

I think I did something bad, I did not apply your "change requested" but I patched the file manually

@Yamakuzure

This comment has been minimized.

Copy link
Collaborator

Yamakuzure commented Feb 22, 2019

I think I did something bad, I did not apply your "change requested" but I patched the file manually

That's the correct way. You can not apply my request, it is just a way of marking a comment. (Unless there is a GitHub feature I missed... 😉 )

@Yamakuzure
Copy link
Collaborator

Yamakuzure left a comment

This looks good, thank you very much!

Yamakuzure added a commit that referenced this pull request Feb 22, 2019

Check if _POSIX_C_SOURCE is defined
If a project uses sd-event.h, either directly or through sd-bus.h,
and _POSIX_C_SOURCE is not defined while -Wundef is set, the build
will break.

Bug: #113
Closes: #113
Closes: #114
Signed-off-by: Sven Eden <sven.eden@prydeworx.com>

Yamakuzure added a commit that referenced this pull request Feb 22, 2019

Check if _POSIX_C_SOURCE is defined
If a project uses sd-event.h, either directly or through sd-bus.h,
and _POSIX_C_SOURCE is not defined while -Wundef is set, the build
will break.

Bug: #113
Closes: #113
Closes: #114
Signed-off-by: Sven Eden <sven.eden@prydeworx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.