Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added support for mime and file contents. #7
Conversation
elopio
added some commits
Oct 1, 2015
fgimenez
reviewed
Oct 2, 2015
| + c <- fileContent.Bytes() | ||
| +} | ||
| + | ||
| +func writeUTF8(b io.Writer, s string) { |
fgimenez
Oct 2, 2015
Collaborator
IMO the possible errors here should be taken into account and returned accordingly.
Also, I think that it would be better if the functions invoked in goroutines have some mean to communicate the possible errors, either with an error channel or returning an instance of a struct with an error field, here are nice examples [1].
Other than that looks fine for me. Maybe the subunit.go file is getting big, but all the functionality seems to be tightly related.
elopio
Oct 6, 2015
Owner
I agree with the errors. Let me get this merged and work in another PR with a solution for all the go routines.
added a commit
that referenced
this pull request
Oct 6, 2015
elopio
merged commit b4173b2
into
master
Oct 6, 2015
elopio
deleted the
mime
branch
Oct 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
elopio commentedOct 1, 2015
No description provided.