From aacfd6e030d56259b374484678a195ae80ecdbf4 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sat, 3 Feb 2024 16:21:03 +0100 Subject: [PATCH] Rename WorkflowDefinitionVersionUpdated to WorkflowDefinitionVersionSelected The callback for when a workflow definition version is updated has been renamed to better reflect its purpose. It is now called "WorkflowDefinitionVersionSelected", as it is triggered when a version is selected, not when it's updated. This change affects several files, with updates to both function and parameter names. --- .../Components/Pages/WorkflowDefinitionEditor.razor | 4 ++-- .../Components/WorkflowDefinitionEditorWrapper.razor | 4 ++-- .../Components/WorkflowDefinitionWorkspace.razor.cs | 6 +++--- .../WorkflowDefinitionEditor/WorkflowDefinitionEditor.razor | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/samples/BlazorApp1/Components/Pages/WorkflowDefinitionEditor.razor b/samples/BlazorApp1/Components/Pages/WorkflowDefinitionEditor.razor index 3274f0f3..dc10b998 100644 --- a/samples/BlazorApp1/Components/Pages/WorkflowDefinitionEditor.razor +++ b/samples/BlazorApp1/Components/Pages/WorkflowDefinitionEditor.razor @@ -1,7 +1,7 @@ @page "/workflow-definitions/{definitionId}" @using Elsa.Api.Client.Resources.WorkflowDefinitions.Models @rendermode InteractiveServer - + Get Current Version @@ -15,7 +15,7 @@ private WorkflowDefinitionEditorWrapper Editor { get; set; } = default!; - private Task OnWorkflowDefinitionVersionUpdated(WorkflowDefinition arg) + private Task WorkflowDefinitionVersionSelected(WorkflowDefinition arg) { return Task.CompletedTask; } diff --git a/src/hosts/Elsa.Studio.Host.CustomElements/Components/WorkflowDefinitionEditorWrapper.razor b/src/hosts/Elsa.Studio.Host.CustomElements/Components/WorkflowDefinitionEditorWrapper.razor index 0a92fd3d..0596a084 100644 --- a/src/hosts/Elsa.Studio.Host.CustomElements/Components/WorkflowDefinitionEditorWrapper.razor +++ b/src/hosts/Elsa.Studio.Host.CustomElements/Components/WorkflowDefinitionEditorWrapper.razor @@ -3,7 +3,7 @@ @inherits BackendComponentBase - + @code @@ -23,7 +23,7 @@ /// Gets or sets the event that occurs when the workflow definition version is updated. /// [Parameter] - public EventCallback WorkflowDefinitionVersionUpdated { get; set; } + public EventCallback WorkflowDefinitionVersionSelected { get; set; } private WorkflowDefinitionEditor WorkflowDefinitionEditor { get; set; } = default!; diff --git a/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/Components/WorkflowDefinitionWorkspace.razor.cs b/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/Components/WorkflowDefinitionWorkspace.razor.cs index 3026ef13..1933d194 100644 --- a/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/Components/WorkflowDefinitionWorkspace.razor.cs +++ b/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/Components/WorkflowDefinitionWorkspace.razor.cs @@ -35,7 +35,7 @@ public partial class WorkflowDefinitionWorkspace : IWorkspace /// Gets or sets the event that occurs when the workflow definition version is updated. /// [Parameter] - public EventCallback WorkflowDefinitionVersionUpdated { get; set; } + public EventCallback WorkflowDefinitionVersionSelected { get; set; } /// /// An event that is invoked when the workflow definition is updated. @@ -63,8 +63,8 @@ public void DisplayWorkflowDefinitionVersion(WorkflowDefinition workflowDefiniti { SelectedWorkflowDefinition = workflowDefinition; - if (WorkflowDefinitionVersionUpdated.HasDelegate) - WorkflowDefinitionVersionUpdated.InvokeAsync(SelectedWorkflowDefinition); + if (WorkflowDefinitionVersionSelected.HasDelegate) + WorkflowDefinitionVersionSelected.InvokeAsync(SelectedWorkflowDefinition); StateHasChanged(); } diff --git a/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/WorkflowDefinitionEditor.razor b/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/WorkflowDefinitionEditor.razor index fbe0218c..84368abc 100644 --- a/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/WorkflowDefinitionEditor.razor +++ b/src/modules/Elsa.Studio.Workflows/Components/WorkflowDefinitionEditor/WorkflowDefinitionEditor.razor @@ -13,7 +13,7 @@ - + @@ -35,7 +35,7 @@ /// Gets or sets the event that occurs when the workflow definition version is updated. /// [Parameter] - public EventCallback WorkflowDefinitionVersionUpdated { get; set; } + public EventCallback WorkflowDefinitionVersionSelected { get; set; } /// /// Gets the currently selected workflow definition version.