Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for refspec matching when triggering the job #41

Merged
merged 9 commits into from Oct 25, 2014

Conversation

Projects
None yet
2 participants
@javiplx
Copy link
Contributor

javiplx commented Sep 8, 2014

No description provided.

@javiplx javiplx referenced this pull request Oct 11, 2014

Merged

Implement global descriptor #44

@javiplx javiplx force-pushed the javiplx:feature/refspec_matching branch from 7d49b77 to 29d15a4 Oct 23, 2014

@elvanja

This comment has been minimized.

Copy link
Owner

elvanja commented Oct 25, 2014

Hey @javiplx!
I am looking at this pull request and I am a bit confused.
Would you mind giving a few more details on what is it exactly trying to do?

@javiplx

This comment has been minimized.

Copy link
Contributor Author

javiplx commented Oct 25, 2014

I have some jobs that should only build tags, in order to publish the artifacts into artifactory.
These jobs have an specific refspec configured, as well as a parametrized branch to build, and without this change every pull (either tag or not) triggers the job.

@javiplx javiplx referenced this pull request Oct 25, 2014

Closed

Checkout to wrong tag #45

@elvanja elvanja merged commit 90c1688 into elvanja:master Oct 25, 2014

@elvanja

This comment has been minimized.

Copy link
Owner

elvanja commented Oct 25, 2014

Merged and added a missing spec and changed some styling, but otherwise merged as-is. Tested manually on several instances, refspec matching works nice. Excellent, thank you :-)

@javiplx javiplx deleted the javiplx:feature/refspec_matching branch Nov 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.