Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git 2x support #42

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@javiplx
Copy link
Contributor

javiplx commented Sep 28, 2014

This is #38 just cleaned

@javiplx javiplx referenced this pull request Sep 28, 2014

Closed

Git 2x support #38

@javiplx javiplx referenced this pull request Oct 11, 2014

Merged

Implement global descriptor #44

BUGFIX : remote url could not be determined
If ConfigurationException is raised, instance.copy is never called, and the test fails
@elvanja

This comment has been minimized.

Copy link
Owner

elvanja commented Oct 25, 2014

Thanks for the work done. I've included the behavior and it is not present in the master branch. Will close manually this pull request because I've chosen to use the version with distributed concerns. Hope you don't mind :)

@elvanja elvanja closed this Oct 25, 2014

@javiplx

This comment has been minimized.

Copy link
Contributor Author

javiplx commented Oct 25, 2014

Let see how it plays with my other changes. At least the template based job creation relies on the work of this PR ...

@javiplx

This comment has been minimized.

Copy link
Contributor Author

javiplx commented Oct 25, 2014

And there is probably a bug there. The prototype for newer git plugin versions is
UserRemoteConfig.new(remote_url, remote_name, remote_refspec, remote_credentials)

javiplx referenced this pull request in jenkinsci/gitlab-hook-plugin Feb 23, 2015

Merge pull request #45 from javiplx/hardening/branch_matching
Hardening/branch matching

Conflicts:
	models/values/project.rb
	spec/values/project_spec.rb

Bundled commits:
	f3b9380 Don't prefix with remote name when simple branch names are configured on SCM
	6baf7db Allow proper matching if using refs style names for branch specifiers
	8082e25 Allow exact matches when configured branch starts with wildcard (Resolves #42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.