Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global descriptor #44

Merged
merged 20 commits into from Oct 26, 2014

Conversation

Projects
None yet
2 participants
@javiplx
Copy link
Contributor

javiplx commented Oct 11, 2014

Added global configuration for the plugin, as well as minimal help files for the UI.

NOTE : this PR is not merged cleanly with #41, and probably neither with #42. If you agree with them, I can easily do a single PR with all the changes and no conflict.

@elvanja elvanja added the enhancement label Oct 25, 2014

@elvanja elvanja merged commit 463b5a0 into elvanja:master Oct 26, 2014

elvanja added a commit that referenced this pull request Oct 26, 2014

elvanja added a commit that referenced this pull request Oct 26, 2014

@elvanja

This comment has been minimized.

Copy link
Owner

elvanja commented Oct 26, 2014

Merged into master. I've synced this with other changes from $41 and #42. Didn't change much from original, just some styling and added support for settings module, in specs and main code as well. The configuration is saved as expected. Need to test the behavior some more. Thanks for the work done!

@javiplx

This comment has been minimized.

Copy link
Contributor Author

javiplx commented Oct 30, 2014

Changes are enough as not allowing merging with/towards the work I'm doing on branch feature/templated_jobs. I believe main reason is the indentation fix from b51cd0e, but also contribution from d9ab46e.
I'll continue working in parallel, and postpone resolution until the time for the PR arrives.

@javiplx javiplx deleted the javiplx:feature/read_config_from_file branch Nov 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.