"keys $local:" crashes Elvish

[xiaq]

This is supposed to list the names of local variables, but it crashes Elvish instead. Something wrong with variable resolution code.

[krader1961]

This seems like a duplicate of issue #668.

[xiaq]

This seems like a duplicate of issue #668.

Well, crashing is a more severe issue than not supporting introspection. I went back and forth but decided to keep them separate since fixing the crash is higher priority.

[krader1961]

Yes, crashing is a more severe issue but it seems to me that actually supporting introspection of the local namespace, and documenting same, is likely to fix the crash. It's not clear what it would mean to fix this crash but not support introspection of $local:. 😄

[krader1961]

It's not clear what it would mean to fix this crash but not support introspection of $local:.

Obviously you could explicitly disallow introspection of the local namespace ; making it unique in its behavior when compared to the other namespaces. Perhaps by raising a specific exception when something like keys $local: is executed (or simply outputting no values). That would fix this issue but would seem to be against the spirit of this issue and #668.

[xiaq]

It's not clear what it would mean to fix this crash but not support introspection of $local:.

Obviously you could explicitly disallow introspection of the local namespace ; making it unique in its behavior when compared to the other namespaces. Perhaps by raising a specific exception when something like keys $local: is executed (or simply outputting no values).

Seems you answered your own question :)

That would fix this issue but would seem to be against the spirit of this issue and #668.

Well, the spirit of this issue is that crashing when using a feature is worse than not supporting a feature.

[krader1961]

@xiaq, Isn't this now a non-issue that should be closed since commit 6822e2c deprecated support for the local namespace?