Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds do not validate variants such as cmd/nodaemon/elvish #1658

Open
krader1961 opened this issue Feb 17, 2023 · 0 comments
Open

CI builds do not validate variants such as cmd/nodaemon/elvish #1658

krader1961 opened this issue Feb 17, 2023 · 0 comments

Comments

@krader1961
Copy link
Contributor

I have been rewriting my scripts that automate building and testing Elvish on my primary server and VMs from Bash to Elvish. When I went to rewrite my ebuild-nodaemon script I noticed it no longer worked due to changes to the Makefile and Elvish source with regard to how build info (e.g., the Git commit ID) is embedded in the Elvish binary. Which caused me to notice that the existing CI configurations do not validate that the ./cmd/nodaemon/elvish variant builds, let alone passes relevant unit tests.

This obviously also applies to targets like ./cmd/withpprof/elvish. However, that specific build target is less likely to suffer bit-rot and therefore probably does not need to be regularly verified by the CI environments.

I can't help but point out that this is yet another argument for reimplementing the interactive history mechanism to not need a daemon. See issue #1222. So rather than adding verification of the ./cmd/nodaemon/elvish variant to the CI configurations it makes more sense to invest the time to replace the dependency on BoltDB, which necessitates a daemon, with a simple flat-file history file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant