Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option parsing is too lenient #958

Closed
krader1961 opened this issue Apr 8, 2020 · 1 comment
Closed

option parsing is too lenient #958

krader1961 opened this issue Apr 8, 2020 · 1 comment
Labels
Milestone

Comments

@krader1961
Copy link
Contributor

@krader1961 krader1961 commented Apr 8, 2020

While responding to feedback on PR #937 I changed the math:is-inf command to accept a &sign option. I was surprised by two things:

  1. I could pass invalid values to the option. In this instance the option should only allow integers (or perhaps float64). Passing an invalid number caused the value to be silently ignored and the default was used instead.

  2. I could specify invalid options. This is true for other builtins that accept options; e.g., echo &sep=: &argle=bargle abc def silently ignores the unexpected &argle option.

@xiaq xiaq added this to the 0.14 milestone Apr 24, 2020
@xiaq xiaq added the t:bug label Apr 24, 2020
@xiaq
Copy link
Member

@xiaq xiaq commented Apr 24, 2020

Sounds like something worth spending some time to fix before next release.

@xiaq xiaq closed this in e72f718 May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.