Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string replace builtin #463

Merged
merged 1 commit into from Aug 5, 2017
Merged

add string replace builtin #463

merged 1 commit into from Aug 5, 2017

Conversation

@tw4452852
Copy link
Contributor

@tw4452852 tw4452852 commented Aug 4, 2017

Signed-off-by: Tw tw19881113@gmail.com

@xiaq
Copy link
Member

@xiaq xiaq commented Aug 4, 2017

Thanks. Functions in re: use the option name &max for the numerical option. Please also use that for consistency.

Signed-off-by: Tw <tw19881113@gmail.com>
@tw4452852
Copy link
Contributor Author

@tw4452852 tw4452852 commented Aug 5, 2017

Done.

@xiaq xiaq merged commit 60db045 into elves:master Aug 5, 2017
1 check passed
@tw4452852 tw4452852 deleted the replaces branch Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants