New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string replace builtin #463

Merged
merged 1 commit into from Aug 5, 2017

Conversation

Projects
None yet
2 participants
@tw4452852
Contributor

tw4452852 commented Aug 4, 2017

Signed-off-by: Tw tw19881113@gmail.com

@xiaq

This comment has been minimized.

Member

xiaq commented Aug 4, 2017

Thanks. Functions in re: use the option name &max for the numerical option. Please also use that for consistency.

add string replace builtin
Signed-off-by: Tw <tw19881113@gmail.com>

@tw4452852 tw4452852 force-pushed the tw4452852:replaces branch from 139d7e9 to 859603f Aug 5, 2017

@tw4452852

This comment has been minimized.

Contributor

tw4452852 commented Aug 5, 2017

Done.

@xiaq xiaq merged commit 60db045 into elves:master Aug 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tw4452852 tw4452852 deleted the tw4452852:replaces branch Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment