New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit: do not share eval context among hook members #515

Merged
merged 1 commit into from Nov 18, 2017

Conversation

Projects
None yet
2 participants
@xofyarg
Contributor

xofyarg commented Nov 16, 2017

Shared context created an internal dependences between members in the
same hook, especially when the previous member willing to modify it,
e.g. a closure will always reset local scope to its lexical one.

edit: do not share eval context among hook members
Shared context created an internal dependences between members in the
same hook, especially when the previous member willing to modify it,
e.g. a closure will always reset local scope to its lexical one.

@xiaq xiaq merged commit 9b97eb0 into elves:master Nov 18, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment