Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appends pathSeparator to dir name #903

Merged
merged 1 commit into from Feb 16, 2020
Merged

Appends pathSeparator to dir name #903

merged 1 commit into from Feb 16, 2020

Conversation

@TacoVox
Copy link
Contributor

TacoVox commented Jan 22, 2020

  • The old quotedPathSeparator was renamed to pathSeparator
  • pathSeparator is not put inside quotes before it is used
  • Instead of using the pathSeparator in quotes a suffix, it is appended
    to the full directory name and afterwords wrapped into quotes iff
    necessary

Not quite sure that is what you intended, but it seems to work for me just fine :)

Looking forward to a small code review from you.

@TacoVox TacoVox requested a review from xiaq Jan 22, 2020
@TacoVox

This comment has been minimized.

Copy link
Contributor Author

TacoVox commented Jan 22, 2020

Will take care of the tests tmrw. 😎

@xiaq

This comment has been minimized.

Copy link
Member

xiaq commented Jan 28, 2020

Hi! Still going to fix the unit tests? :)

@TacoVox

This comment has been minimized.

Copy link
Contributor Author

TacoVox commented Jan 29, 2020

Hi @xiaq,
sorry for my delay here. Quite busy at work these days. Fixed all except one. Will try to attend it as soon as possible. Haven't forgotten about this one here ;)

Thanks for your patience!

@TacoVox TacoVox force-pushed the TacoVox:quote-fix branch 3 times, most recently from c718160 to 25d2363 Jan 29, 2020
@TacoVox

This comment has been minimized.

Copy link
Contributor Author

TacoVox commented Jan 29, 2020

Managed to fix it before work! Thanks for your patience, @xiaq. 🌵

pkg/edit/complete/generators.go Outdated Show resolved Hide resolved
pkg/edit/complete/complete_test.go Outdated Show resolved Hide resolved
* The old quotedPathSeparator was renamed to pathSeparator
* pathSeparator is not put inside quotes before it is used
* Instead of using the pathSeparator in quotes a suffix, it is appended
  to the full directory name and afterwords wrapped into quotes iff
  necessary
* Updates test caes

This is a fix for #897.
@TacoVox TacoVox force-pushed the TacoVox:quote-fix branch from 25d2363 to add057f Feb 1, 2020
@xiaq xiaq merged commit 8214ca3 into elves:master Feb 16, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TacoVox TacoVox deleted the TacoVox:quote-fix branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.