Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ember 3.12 #140

Merged
merged 9 commits into from Aug 30, 2019
Merged

Conversation

@andreyfel
Copy link
Contributor

andreyfel commented Aug 27, 2019

Use ember-cli-update to update everything.
Update other deps as well.
Run codemods.

andreyfel added 7 commits Aug 27, 2019
Use ember-cli-update to update blueprints and dependencies to 3.12.
Update all other dependencies to latest.
It was failing on latest Ember.
@andreyfel

This comment has been minimized.

Copy link
Contributor Author

andreyfel commented Aug 27, 2019

@elwayman02 Could you please look at this PR? I also have another PR on top of this PR to fix a memory leak.

"@ember/optional-features": "^0.7.0",
"broccoli-asset-rev": "^3.0.0",
"ember-cli": "~3.12.0",
"ember-cli-addon-docs": "^0.6.14",

This comment has been minimized.

Copy link
@elwayman02

elwayman02 Aug 27, 2019

Owner

I suspect that this change will break the dummy app in weird ways, because the forked changes I made never got merged into the master branch.

This comment has been minimized.

Copy link
@elwayman02

elwayman02 Aug 27, 2019

Owner

I filed a ticket for this. It shouldn't be too terrible to find an alternative in this version of addon-docs, but you don't have to address it if you want to just rollback this change for now.

#141

This comment has been minimized.

Copy link
@andreyfel

andreyfel Aug 28, 2019

Author Contributor

Unfortunately, that fork doesn't work with the latest Ember, so, I had to update it to latest ember-cli-addon-docs.

I looked at the dummy app and fixed the issues with it.
I just removed the multi-yield and the Ember logo, because the word "Ember" is in the hero already with the latest addon version.

andreyfel added 2 commits Aug 28, 2019
It was renamed in ember-cli-addon-docs@0.3.0
That was in a fork, however it was never merged to upstream.
In fact that customisation doesn't give much to the look of the page.
It was adding the Ember logo to the hero section.
With the latest release of `ember-cli-addon-docs` it shows "Ember" label
in the `hero` section. So, it makes showing logo redundant.
It is safe just to remove the logo at all.
@elwayman02

This comment has been minimized.

Copy link
Owner

elwayman02 commented Aug 30, 2019

Thanks, this looks great!

@elwayman02 elwayman02 merged commit b430bf8 into elwayman02:master Aug 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andreyfel andreyfel deleted the andreyfel:update-to-new-ember branch Sep 2, 2019
},
"engines": {
"node": "6.* || 8.* || >= 10.*"
"node": "8.* || >= 10.*"

This comment has been minimized.

Copy link
@Turbo87

Turbo87 Dec 16, 2019

@elwayman02 @tylerturdenpants when releasing this please keep in mind that this is a breaking change :)

also, do you have time to put out a new release including this change? would very much like to use Babel 7 in our app 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.