Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsubscribe memory leak #142

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@andreyfel
Copy link
Contributor

andreyfel commented Sep 2, 2019

In user-activity's willDestroy there was an forEach loop by
this._eventsListened where inside the callback items were removed
from the array which was being iterated. As a result one item left
non-cleaned up.

Use regular while loop to clean up the array and add a test which
ensures that event listeners were removed.

In `user-activity`'s `willDestroy` there was an forEach loop by
`this._eventsListened` where inside the callback items were removed
from the array which was being iterated. As a result one item left
non-cleaned up.

Use regular while loop to clean up the array and add a test which
ensures that event listeners were removed.
@elwayman02

This comment has been minimized.

Copy link
Owner

elwayman02 commented Sep 2, 2019

Thank you for catching this! I'll get everything ready for release tomorrow hopefully.

@elwayman02 elwayman02 merged commit 62b9c8b into elwayman02:master Sep 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andreyfel

This comment has been minimized.

Copy link
Contributor Author

andreyfel commented Sep 3, 2019

Thanks! Looking forward to new release!

@andreyfel andreyfel deleted the andreyfel:teardown-memory-leak branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.