Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kfp dependency #1104

Merged
merged 1 commit into from Dec 7, 2020
Merged

Upgrade kfp dependency #1104

merged 1 commit into from Dec 7, 2020

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Nov 24, 2020

This PR

Fixes #1067

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Nov 24, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added the component:build build and build related issues(dependencies and docker) label Nov 24, 2020
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptitzler
Copy link
Member Author

Forgot to mention that I tested this by running the example NOA pipeline and exporting it as YAML + Python DSL

@ptitzler
Copy link
Member Author

Confirmed that the upgrade resolves #1067

@lresende
Copy link
Member

@ptitzler Do we need to update our minimum requirements for KFP Server?

@lresende lresende removed the component:build build and build related issues(dependencies and docker) label Nov 30, 2020
@ptitzler
Copy link
Member Author

  • According to the KFP versioning policy changes in 1.1.x should be backwards compatible with 1.0 and everything should still continue to work.
  • I am not aware of any place where we currently document a minimum supported version

@ptitzler
Copy link
Member Author

ptitzler commented Dec 2, 2020

The test failure is not related to the changes in this PR

@lresende lresende added this to the 1.4.3 milestone Dec 7, 2020
@lresende lresende merged this pull request into elyra-ai:master Dec 7, 2020
lresende pushed a commit that referenced this pull request Dec 7, 2020
lresende pushed a commit that referenced this pull request Dec 7, 2020
@ptitzler ptitzler deleted the patch-1 branch December 14, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Kubeflow Pipelines No Host Specified Error
3 participants