New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional property for pipeline response #1364
Conversation
Adds an additional `git_url` property to the submission dialog box to provide users a link to the location of the DAG in the GitHub repository Fixes elyra-ai#1362
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Note the Anyway, just my $0.02 :) |
@lresende - not able to access the repo cause you guys dont have permissions via UI I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some frontend review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The front end code look good, note that I haven't reviewed the backend code or tested this locally though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just had some suggestions and a question about what your findings were with kwargs.
@kevin-bates, thanks kevin, yeah didnt need the kwargs or super call. cleaned it up a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alan. Full disclosure: I didn't test this other than by inspection.
Not introduced by this PR but also not resolved yet is the path issue:
yield the following URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected for KFP and AA, aside from the URL issue I mentioned.
@ptitzler - added a fix for the extra slash in the generated URL |
Can you please add automated tests for |
Adds an additional
git_url
property to the submission dialog boxto provide users a link to the location of the DAG in the GitHub
repository
Fixes #1362
Developer's Certificate of Origin 1.1