Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional property for pipeline response #1364

Merged
merged 6 commits into from Mar 5, 2021

Conversation

akchinSTC
Copy link
Member

Adds an additional git_url property to the submission dialog box
to provide users a link to the location of the DAG in the GitHub
repository

Fixes #1362

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Adds an additional `git_url` property to the submission dialog box
to provide users a link to the location of the DAG in the GitHub
repository

Fixes elyra-ai#1362
@elyra-bot
Copy link

elyra-bot bot commented Mar 3, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC
Copy link
Member Author

image

@lresende
Copy link
Member

lresende commented Mar 3, 2021

Clicking the GitHub link:
image

Note the double slash on the URL, even after #1363, also, because we use the token to access the repo, there is no guarantee that the user submitting the pipeline will have access to the shared git repository used to store the DAGs.

Anyway, just my $0.02 :)

@akchinSTC
Copy link
Member Author

@lresende - not able to access the repo cause you guys dont have permissions via UI I think.
Ill strip out the extra slash in the url context

packages/pipeline-editor/src/PipelineService.tsx Outdated Show resolved Hide resolved
elyra/pipeline/processor.py Outdated Show resolved Hide resolved
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some frontend review

packages/pipeline-editor/src/PipelineService.tsx Outdated Show resolved Hide resolved
packages/pipeline-editor/src/PipelineService.tsx Outdated Show resolved Hide resolved
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end code look good, note that I haven't reviewed the backend code or tested this locally though

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just had some suggestions and a question about what your findings were with kwargs.

elyra/pipeline/processor.py Outdated Show resolved Hide resolved
elyra/pipeline/processor_airflow.py Outdated Show resolved Hide resolved
elyra/pipeline/processor_airflow.py Outdated Show resolved Hide resolved
elyra/pipeline/processor_kfp.py Outdated Show resolved Hide resolved
elyra/pipeline/processor.py Outdated Show resolved Hide resolved
@akchinSTC
Copy link
Member Author

@kevin-bates, thanks kevin, yeah didnt need the kwargs or super call. cleaned it up a bit.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan. Full disclosure: I didn't test this other than by inspection.

@ptitzler
Copy link
Member

ptitzler commented Mar 5, 2021

Not introduced by this PR but also not resolved yet is the path issue:
The following runtime config settings

https://api.github.com
akchinstc/test-repo
main

yield the following URL:

https://github.com//akchinstc/test-repo/tree/main

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for KFP and AA, aside from the URL issue I mentioned.

@akchinSTC
Copy link
Member Author

@ptitzler - added a fix for the extra slash in the generated URL

@lresende lresende merged commit 3946a3b into elyra-ai:master Mar 5, 2021
@akchinSTC akchinSTC deleted the i-1362 branch March 5, 2021 02:17
@ptitzler
Copy link
Member

ptitzler commented Mar 5, 2021

Can you please add automated tests for get_github_url? I am sure we'll hit issues in the future once we see more URLs in the wild that'll break the current logic. This way we can just keep adding more tests when that happens.

@lresende lresende added this to the 2.1.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for custom properties in elyra.pipeline.processor.PipelineProcessorResponse
5 participants