Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LabIcon in code-snippet package #463

Merged
merged 4 commits into from May 1, 2020
Merged

Conversation

ajbozarth
Copy link
Member

Update the icon usage in code snippets to use LabIcons

This includes:

  • Moving the code-snippet logo into application
  • tweaking the svg viewBox to remove excess space around the icon
    which make it properly fill the width off the icon in the css
  • replace all icons set with css with LabIcon instances
  • some minor icon css size tweaking

Fixes #443
Fixes #430

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Update the icon usage in code snippets to use LabIcons

This includes:
- Moving the code-snippet logo into application
- tweaking the svg viewBox to remove excess space around the icon
which make it properly fill the width off the icon in the css
- replace all icons set with css with LabIcon instances
- some minor icon css size tweaking

Fixes elyra-ai#443
Fixes elyra-ai#430
Co-authored-by: va barbosa <vabarbosa@users.noreply.github.com>
Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look into failing tests, doesn't look like they're caused by your changes.
Otherwise, LGTM.

@ajbozarth
Copy link
Member Author

The tests actually consistently fail locally as well, I'm taking a look to figure out why

@ajbozarth
Copy link
Member Author

I've tracked down the cause: It's the same issue as has been raised in the git extension jupyterlab/jupyterlab-git#604
I'm testing a work around but given this is now hitting us twice I'm going to open a PR on lab with my idea I suggested in the git pr

@ajbozarth
Copy link
Member Author

I've pushed a workaround fix for the tests and will be opening a PR on lab to fix it there since it's also happening to jupyterlab-git

@lresende lresende merged commit 82669c9 into elyra-ai:master May 1, 2020
@ajbozarth ajbozarth deleted the icons branch May 1, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to LabIcon in Code Snippets Update arrow icons in code snippets
4 participants