New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LabIcon in code-snippet package #463
Conversation
Update the icon usage in code snippets to use LabIcons This includes: - Moving the code-snippet logo into application - tweaking the svg viewBox to remove excess space around the icon which make it properly fill the width off the icon in the css - replace all icons set with css with LabIcon instances - some minor icon css size tweaking Fixes elyra-ai#443 Fixes elyra-ai#430
Co-authored-by: va barbosa <vabarbosa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should look into failing tests, doesn't look like they're caused by your changes.
Otherwise, LGTM.
The tests actually consistently fail locally as well, I'm taking a look to figure out why |
I've tracked down the cause: It's the same issue as has been raised in the git extension jupyterlab/jupyterlab-git#604 |
I've pushed a workaround fix for the tests and will be opening a PR on lab to fix it there since it's also happening to jupyterlab-git |
Update the icon usage in code snippets to use LabIcons
This includes:
which make it properly fill the width off the icon in the css
Fixes #443
Fixes #430
Developer's Certificate of Origin 1.1