confused about highlighting #29

Closed
gad2103 opened this Issue May 17, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@gad2103

gad2103 commented May 17, 2014

hi there i'm trying to get highlighting to work correctly like in the image below:
687474703a2f2f6661726d382e737461746963666c69636b722e636f6d2f373233342f373138353536303238335f313032663662373533642e6a7067

however, i get this:
screen shot 2014-05-17 at 3 22 07 pm

i don't want the highlighting to happen when i have unquoted json fields. for example if i am making a json config file that doesn't use any quotes at all (like in the first image attached).

am i doing something wrong? help would be greatly appreciated!

@elzr

This comment has been minimized.

Show comment Hide comment
@elzr

elzr May 21, 2014

Owner

Hi @gad2103! Thanks for trying the plugin. So the first image is not showing quotes but it does have them, they're just being concealed, which is a relatively new Vim feature and half the point of this plugin ;) I just added a GIF here and to the readme that should clarify what's the expected behavior.

showcase

The other half of the point of this plugin is to have specific warnings for JSON, which wouldn't allow unquoted keys or values (and a whole sort of other subtle but important differences from Javascript). Anyway, you do bring an interesting point and I created a way to disable the warnings by adding a let g:vim_json_warnings=0 to your vimrc.

Owner

elzr commented May 21, 2014

Hi @gad2103! Thanks for trying the plugin. So the first image is not showing quotes but it does have them, they're just being concealed, which is a relatively new Vim feature and half the point of this plugin ;) I just added a GIF here and to the readme that should clarify what's the expected behavior.

showcase

The other half of the point of this plugin is to have specific warnings for JSON, which wouldn't allow unquoted keys or values (and a whole sort of other subtle but important differences from Javascript). Anyway, you do bring an interesting point and I created a way to disable the warnings by adding a let g:vim_json_warnings=0 to your vimrc.

@elzr elzr closed this May 21, 2014

@gad2103

This comment has been minimized.

Show comment Hide comment
@gad2103

gad2103 May 21, 2014

thanks eli! very helpful. i'll disable the warnings :)

On Tue, May 20, 2014 at 8:13 PM, Eli Parra notifications@github.com wrote:

Closed #29 #29.


Reply to this email directly or view it on GitHubhttps://github.com/elzr/vim-json/issues/29#event-123155690
.

Gabriel Duncan

Developer of Webs

Phone: (347) 829 7122

DISCLAIMER: This is a notification that this email is automatically return
receipt enabled. Upon opening this email, notification is sent to the
sender confirming that it has been viewed.

gad2103 commented May 21, 2014

thanks eli! very helpful. i'll disable the warnings :)

On Tue, May 20, 2014 at 8:13 PM, Eli Parra notifications@github.com wrote:

Closed #29 #29.


Reply to this email directly or view it on GitHubhttps://github.com/elzr/vim-json/issues/29#event-123155690
.

Gabriel Duncan

Developer of Webs

Phone: (347) 829 7122

DISCLAIMER: This is a notification that this email is automatically return
receipt enabled. Upon opening this email, notification is sent to the
sender confirming that it has been viewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment