-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefixes and suffixes in citar-markdown-insert-citation
#786
Comments
citar-markdown-insert-citation
citar-markdown-insert-citation
That's weird; testing just now, I don't see that. This is what I get when inserting without affix and with respectively. # Testing ...
[@burwell2014]
[see @kohn2008, p12] |
Okay, I now realize that this is not an intended behavior: looking at Presumably in your case the value of |
No; I tried in both my default doom setup, and a minimal custom one. Seems regardless it would be better for it to check for a non-empty string? Care to submit a PR for that? |
Sure. To confirm, this would just involve replacing |
I believe so.
|
By the way, in case this is helpful to others, the reason we were getting different values for |
When I run
citar-insert-citation
in a Markdown buffer and select the work I want to cite, the identifier is inserted preceded by a space and followed by a comma and a space, e.g.[ @Ord2020PrecipiceExistentialRisk, ]
. The function responsible for this behavior iscitar-markdown-insert-citation
(specifically, the lines(prenote (if (string= "" prenote) "" (concat prenote " ")))
and(postnote (if (string= "" postnote) "" (concat ", " postnote)))
. ) I would prefer not to have these extra characters inserted when no prefix or suffix is provided, which would also be consistent with how citations are inserted in org-mode buffers. Would it make sense to add a user option to control this behavior?The text was updated successfully, but these errors were encountered: