Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eclimd-start sentinel to not error when not in project #99

Merged
merged 1 commit into from Sep 28, 2018

Conversation

nverno
Copy link
Contributor

@nverno nverno commented Sep 25, 2018

Stops eclimd-start process setinel from erroring when started
from directory that is not already an eclim project.

@nverno
Copy link
Contributor Author

nverno commented Sep 25, 2018

solve "error in process-filter" #96

@coveralls
Copy link

coveralls commented Sep 25, 2018

Coverage Status

Coverage increased (+0.1%) to 16.667% when pulling e955e5e on nverno:eclimd-sentinel into 99fda18 on emacs-eclim:master.

@nloyola
Copy link
Collaborator

nloyola commented Sep 26, 2018

Hi @nverno. I'm trying out this commit, but when I do M-x eclimd-start after opening a Java file in my project I get: Not currently in eclim project.

I'll look into it further to see if it's my setup.

@nverno
Copy link
Contributor Author

nverno commented Sep 26, 2018

Yea, I see the same issue. There also is an issue with eclimd-stop, which hangs on accept-process-output.

@nverno
Copy link
Contributor Author

nverno commented Sep 26, 2018

Hm, it breaks the buttercup tests though since the mockup isnt a real process. What to do...
It would be nice to have a better mock-up to write tests against.

@nloyola
Copy link
Collaborator

nloyola commented Sep 27, 2018

Hi @nverno. I tried your latest commit and the start sentinel portion works for me now. However, stopping eclimd still hangs and the tests fail. Do you want me to look into that?

@nverno
Copy link
Contributor Author

nverno commented Sep 27, 2018

I think the stopping eclimd should add a check in eclimd--match-process-output, eg. line 255

(while (and (process-live-p eclimd-process) (not finished-p)
   ....)

but it breaks the previous buttercup tests that rely on the fake mock-up process. The called-interactive-p is hacky and the specs work when I run them locally (emacs 27.0.5), but I don't know if that is due to a change in the function or something else.

I've only just started looking into buttercup, so I'm not sure how to remedy the testing sitch.

@nverno
Copy link
Contributor Author

nverno commented Sep 27, 2018

I'll break it into two issues, this just deals with the eclim starting outstide project part

@nloyola nloyola merged commit 3acc286 into emacs-eclim:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants