Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd evil-collection-magit-todos.el #177
Conversation
| @@ -0,0 +1,46 @@ | ||
| ;;; evil-collection-magit-todos.el --- Bindings for `magit-todos' -*- lexical-binding: t -*- | ||
| ;; Copyright (C) 2018 James Nguyen |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Looks good to me but I haven't tested it (yet). |
justbur
referenced this pull request
Jul 12, 2018
Closed
[feature request] support for magic-todos #50
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
fbergroth
Jul 12, 2018
Contributor
Hmm, the unbinding should probably be made in a hook. I'll have a look at
it later.
|
Hmm, the unbinding should probably be made in a hook. I'll have a look at
it later.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jojojames
Jul 12, 2018
Collaborator
Awesome, I was going to add this myself but you beat me to it.
Let me know when you think this is ready for merge.
|
Awesome, I was going to add this myself but you beat me to it. Let me know when you think this is ready for merge. |
jojojames
referenced this pull request
Jul 13, 2018
Closed
Feature Request: Optionally disable keybindings #31
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
fbergroth
Jul 13, 2018
Contributor
@jojojames Okay, updated. I think it was fine before, but now the "gT" binding is only active when the minor mode is active.
|
@jojojames Okay, updated. I think it was fine before, but now the "gT" binding is only active when the minor mode is active. |
jojojames
merged commit 9b692a1
into
emacs-evil:master
Jul 13, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fbergroth commentedJul 12, 2018
No description provided.