Add evil-collection-magit-todos.el #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambrevar
reviewed
Jul 12, 2018
| @@ -0,0 +1,46 @@ | |||
| ;;; evil-collection-magit-todos.el --- Bindings for `magit-todos' -*- lexical-binding: t -*- | |||
|
|
|||
| ;; Copyright (C) 2018 James Nguyen | |||
There was a problem hiding this comment.
@fbergroth: Your name should go here.
There was a problem hiding this comment.
Ah right, thanks. I don't care to update it though :)
|
Looks good to me but I haven't tested it (yet). |
|
Hmm, the unbinding should probably be made in a hook. I'll have a look at
it later.
|
|
Awesome, I was going to add this myself but you beat me to it. Let me know when you think this is ready for merge. |
|
@jojojames Okay, updated. I think it was fine before, but now the "gT" binding is only active when the minor mode is active. |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.