Can't dot repeat when surrounding with counted movements

[jvmcarneiro]

When I surround with a count like ys2w" and try to repeat it with ., it does so as if I didn't input any count (ysw").

For example:
Using ys2w" on a text fragment like -word yields "-word";
Dot repeating it on another fragment -another yields "-"another.

Am I missing something? Is this expected behaviour?

[ninrod]

I suspect this: emacs-evil/evil#9. Summoning @justbur who just did touch some lines regarding the repeatition support.

[justbur]

I didn't change anything that would affect ysiw". This is a different problem. My changes only affected surrounding with functions or tags.

By the way, in general the way evil-surround implements repeat (especially for ys) is pretty brittle and probably should be rewritten.

[ninrod]

@justbur, maybe related to emacs-evil/evil#9?

yeah. I wish I had the lisp and evil knowledge to do it.

[dsdshcym]

This patch makes repeat work with counted motion:
evil-this-motion-count.diff.txt

But I'm not sure if it's the right way to fix this issue.

[ninrod]

thank you @dsdshcym.

Do you want to fill out a PR? You could include a test to verify that the behaviour is correctly implemented.

I'll try your patch locally, anyway. Thanks again.

[ninrod]

346d4d8 by @dsdshcym closes this.